Patch Detail
Show a patch.
GET /api/1.1/patches/11623/?format=api
{ "id": 11623, "url": "https://patchwork.libcamera.org/api/1.1/patches/11623/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11623/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210318125521.43278-3-jacopo@jmondi.org>", "date": "2021-03-18T12:55:21", "name": "[libcamera-devel,2/2] android: camera_device: Do not default External to Front", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "02ecbb313700bdb0925af050136aa0f4bcabb78c", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11623/mbox/", "series": [ { "id": 1802, "url": "https://patchwork.libcamera.org/api/1.1/series/1802/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1802", "date": "2021-03-18T12:55:19", "name": "libcamera: Do not default the location property", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1802/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11623/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11623/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20C9CC32E1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Mar 2021 12:54:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F35BD602E3;\n\tThu, 18 Mar 2021 13:54:57 +0100 (CET)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A040068D5E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Mar 2021 13:54:55 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-22-58-175.retail.telecomitalia.it [79.22.58.175])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id CC1351BF205;\n\tThu, 18 Mar 2021 12:54:54 +0000 (UTC)" ], "X-Originating-IP": "79.22.58.175", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Mar 2021 13:55:21 +0100", "Message-Id": "<20210318125521.43278-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210318125521.43278-1-jacopo@jmondi.org>", "References": "<20210318125521.43278-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] android: camera_device: Do not\n\tdefault External to Front", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that the camera location is not defaulted anymore in the library but\ndoesn't get registered if the firmware interface does not provide the\ninformation, do not default it to FRONT if LocationExternal is reported.\n\nTo maintain compatibility with CTS requirements, default location to\nFRONT only if the camera property is not available.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a81e3c905d6c..a65b978ffc32 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -376,11 +376,7 @@ int CameraDevice::initialize()\n \t\t\tfacing_ = CAMERA_FACING_BACK;\n \t\t\tbreak;\n \t\tcase properties::CameraLocationExternal:\n-\t\t\t/*\n-\t\t\t * \\todo Set this to EXTERNAL once we support\n-\t\t\t * HARDWARE_LEVEL_EXTERNAL\n-\t\t\t */\n-\t\t\tfacing_ = CAMERA_FACING_FRONT;\n+\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n \t\t\tbreak;\n \t\t}\n \t}\n", "prefixes": [ "libcamera-devel", "2/2" ] }