Patch Detail
Show a patch.
GET /api/1.1/patches/11619/?format=api
{ "id": 11619, "url": "https://patchwork.libcamera.org/api/1.1/patches/11619/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11619/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210318103941.18837-7-jacopo@jmondi.org>", "date": "2021-03-18T10:39:40", "name": "[libcamera-devel,6/7] libcamera: ipu3: imgu: Add pipe calculation debug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c03240eeb231ce1980c3612f326397df04e4262", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/11619/mbox/", "series": [ { "id": 1801, "url": "https://patchwork.libcamera.org/api/1.1/series/1801/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1801", "date": "2021-03-18T10:39:34", "name": "ipu3: imgu: Improve ImgU calculation procedure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1801/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11619/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11619/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F9CCBD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Mar 2021 10:39:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEDA768D6F;\n\tThu, 18 Mar 2021 11:39:25 +0100 (CET)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2402368D6D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Mar 2021 11:39:21 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-22-58-175.retail.telecomitalia.it [79.22.58.175])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 69134C0002;\n\tThu, 18 Mar 2021 10:39:20 +0000 (UTC)" ], "X-Originating-IP": "79.22.58.175", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Mar 2021 11:39:40 +0100", "Message-Id": "<20210318103941.18837-7-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210318103941.18837-1-jacopo@jmondi.org>", "References": "<20210318103941.18837-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 6/7] libcamera: ipu3: imgu: Add pipe\n\tcalculation debug", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add pipe calculation debug with a new associated log category.\n\nThis helps compare the pipe calculation with the one performed by the\npython script.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 24 ++++++++++++++++++++++++\n 1 file changed, 24 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex ccc85864fc39..b6a1fe34494e 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -23,6 +23,7 @@\n namespace libcamera {\n \n LOG_DECLARE_CATEGORY(IPU3)\n+LOG_DEFINE_CATEGORY(IMGUPIPE)\n \n namespace {\n \n@@ -128,6 +129,8 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \tunsigned int ifHeight;\n \tfloat bdsHeight;\n \n+\tLOG(IMGUPIPE, Debug) << \"BDS sf: \" << bdsSF << \" BDS width: \" << bdsWidth;\n+\n \tif (!isSameRatio(pipe->input, gdc)) {\n \t\tunsigned int foundIfHeights[2] = { 0, 0 };\n \t\tfloat estIFHeight = (iif.width * gdc.height) /\n@@ -135,6 +138,9 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\testIFHeight = std::clamp<float>(estIFHeight, minIFHeight, iif.height);\n \n \t\tifHeight = utils::alignUp(estIFHeight, IF_ALIGN_H);\n+\t\tLOG(IMGUPIPE, Debug) << \"Estimate IF Height: \" << estIFHeight\n+\t\t\t\t << \" IF Height: \" << ifHeight;\n+\n \t\twhile (ifHeight >= minIFHeight && ifHeight <= iif.height &&\n \t\t ifHeight / bdsSF >= minBDSHeight) {\n \n@@ -176,6 +182,11 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\tif (foundIfHeights[0] || foundIfHeights[1]) {\n \t\t\tunsigned int bdsIntHeight = static_cast<unsigned int>(bdsHeight);\n \n+\t\t\tLOG(IMGUPIPE, Debug)\n+\t\t\t\t<< \"IF: \" << Size(iif.width, ifHeight).toString()\n+\t\t\t\t<< \"BDS: \" << Size(bdsWidth, bdsIntHeight).toString()\n+\t\t\t\t<< \"GDC: \" << gdc.toString();\n+\n \t\t\tpipeConfigs.push_back({ bdsSF, { iif.width, ifHeight },\n \t\t\t\t\t\t{ bdsWidth, bdsIntHeight }, gdc });\n \t\t\treturn;\n@@ -190,6 +201,12 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \n \t\t\t\tif (!(ifHeight % IF_ALIGN_H) &&\n \t\t\t\t !(bdsIntHeight % BDS_ALIGN_H)) {\n+\n+\t\t\t\t\tLOG(IMGUPIPE, Debug)\n+\t\t\t\t\t\t<< \"IF: \" << Size(iif.width, ifHeight).toString()\n+\t\t\t\t\t\t<< \"BDS: \" << Size(bdsWidth, bdsIntHeight).toString()\n+\t\t\t\t\t\t<< \"GDC: \" << gdc.toString();\n+\n \t\t\t\t\tpipeConfigs.push_back({ bdsSF, { iif.width, ifHeight },\n \t\t\t\t\t\t\t\t{ bdsWidth, bdsIntHeight }, gdc });\n \t\t\t\t}\n@@ -269,6 +286,8 @@ Size calculateGDC(ImgUDevice::Pipe *pipe)\n \tgdc.width = main.width * sf;\n \tgdc.height = main.height * sf;\n \n+\tLOG(IMGUPIPE, Debug) << \"GDC: \" << gdc.toString();\n+\n \treturn gdc;\n }\n \n@@ -286,6 +305,11 @@ FOV calcFOV(const Size &in, const ImgUDevice::PipeConfig &pipe)\n \tfov.w = (inW - (ifCropW + gdcCropW)) / inW;\n \tfov.h = (inH - (ifCropH + gdcCropH)) / inH;\n \n+\tLOG(IMGUPIPE, Debug)\n+\t\t<< \"IF (\" << pipe.iif.toString() << \") - BDS (\"\n+\t\t<< pipe.bds.toString() << \") - GDC (\" << pipe.gdc.toString()\n+\t\t<< \") -> FOV: \" << fov.w << \"x\" << fov.h;\n+\n \treturn fov;\n }\n \n", "prefixes": [ "libcamera-devel", "6/7" ] }