Patch Detail
Show a patch.
GET /api/1.1/patches/11618/?format=api
{ "id": 11618, "url": "https://patchwork.libcamera.org/api/1.1/patches/11618/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11618/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210318103941.18837-6-jacopo@jmondi.org>", "date": "2021-03-18T10:39:39", "name": "[libcamera-devel,5/7] libcamera: ipu3: imgu: Fix BSD height size comparison", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "931fde495cfb4efac1b850d57c554801313690f8", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/11618/mbox/", "series": [ { "id": 1801, "url": "https://patchwork.libcamera.org/api/1.1/series/1801/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1801", "date": "2021-03-18T10:39:34", "name": "ipu3: imgu: Improve ImgU calculation procedure", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1801/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11618/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11618/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72BA4C32E2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Mar 2021 10:39:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2151468D7C;\n\tThu, 18 Mar 2021 11:39:25 +0100 (CET)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AAB968D6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Mar 2021 11:39:20 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-22-58-175.retail.telecomitalia.it [79.22.58.175])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 8A7E9C0004;\n\tThu, 18 Mar 2021 10:39:19 +0000 (UTC)" ], "X-Originating-IP": "79.22.58.175", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Mar 2021 11:39:39 +0100", "Message-Id": "<20210318103941.18837-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210318103941.18837-1-jacopo@jmondi.org>", "References": "<20210318103941.18837-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/7] libcamera: ipu3: imgu: Fix BSD height\n\tsize comparison", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix a size comparison when iterating on the BDS sizes to align it with\nthe python scritp implementation.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex 89a01bddbed2..ccc85864fc39 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -182,7 +182,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n \t\t}\n \t} else {\n \t\tifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n-\t\twhile (ifHeight > minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n+\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n \n \t\t\tbdsHeight = ifHeight / bdsSF;\n \t\t\tif (std::fmod(ifHeight, 1.0) == 0 && std::fmod(bdsHeight, 1.0) == 0) {\n", "prefixes": [ "libcamera-devel", "5/7" ] }