Patch Detail
Show a patch.
GET /api/1.1/patches/11603/?format=api
{ "id": 11603, "url": "https://patchwork.libcamera.org/api/1.1/patches/11603/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11603/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210317100211.1067585-6-naush@raspberrypi.com>", "date": "2021-03-17T10:02:09", "name": "[libcamera-devel,5/7] ipa: raspberrypi: Remove unused member variables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "bbade20539c6982503458df8ce29d0f75428fe83", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11603/mbox/", "series": [ { "id": 1799, "url": "https://patchwork.libcamera.org/api/1.1/series/1799/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1799", "date": "2021-03-17T10:02:06", "name": "Raspberry Pi: ipa::init() restructuring", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1799/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11603/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11603/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0B2EBD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Mar 2021 10:02:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68BAF68D69;\n\tWed, 17 Mar 2021 11:02:27 +0100 (CET)", "from mail-ed1-x532.google.com (mail-ed1-x532.google.com\n\t[IPv6:2a00:1450:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 782ED68D60\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Mar 2021 11:02:22 +0100 (CET)", "by mail-ed1-x532.google.com with SMTP id x21so1482178eds.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Mar 2021 03:02:22 -0700 (PDT)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tp24sm12061179edt.5.2021.03.17.03.02.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Mar 2021 03:02:21 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"p/UYiYC/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=i0Iw9t0eXvZQY0D2HztYUW+2hZU4Zj5K8M2ZQyPbQEM=;\n\tb=p/UYiYC/PvkKpoQ7HG9xvsiR676BKSAJcoDM+mmemyImGh+UFb9bJUSuXbgijE2NW2\n\t3V8bi39XP8HU4SvvzWUTwwWWJdrKeGkFM8uphU95k+RY0QZRQbkB6x+myIS+D3IeAvBk\n\tSlLSBp1bXdAlng3WuUwlny6u1OES2Fzz5IplyHFTYvp0S56DZpiw3tQS4W2/p6poLQt/\n\td2cYLX6/W2J5UzeQ1jQAdqQ3Yp3xwzYLKtEAsSpiXa6dYwiiJdMcyqN61RDMPUVPMwJI\n\t6nsAPvxBB9JCortIoWawrkoQTPbEmE5F594ysLX+PwgR6w/lQMz9GStZqHPV1Bgud7Pb\n\tB+wg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=i0Iw9t0eXvZQY0D2HztYUW+2hZU4Zj5K8M2ZQyPbQEM=;\n\tb=eDaUhpU+OkaaRXN/GsyzHGbQGqfL2UXIJXKU9TXJqZ510t5J2ryjjfv+PVuKF4dR0e\n\t8b2lst+Frtn/2N+4pqNHe8ybW3QVOUx9okLskHux+3Cngoj/yH+Iq8AtNdCFEQXM/q/M\n\tDel4z9KmbF4KtVPmmsvaTyg50DdQRGGSfVPNIo05smaTI+wiAF+kd2HBzEyTWC2fsMPT\n\tUpSEZUEKrNWhOXOSMDVMV60FadOAf35ElDd+cmtmWaxtQbzrn9zGRuBO42b8+iVE9i66\n\tprUA6C9cSsu/4ixgS44O3HnwSeagbzlmhERBQcLJkaKmMTz69muVeW5nw90UFPTEvlF/\n\tRS9g==", "X-Gm-Message-State": "AOAM5315mz6krmUPA5oA1Zj0BsDYgpgWJWBBkj8uHwO28IMH9JXDyKVd\n\tQMUxewq+5mVpMZH2lzA+CMOTK/huo2f3Eg==", "X-Google-Smtp-Source": "ABdhPJyY96jlYd7Ec/ex3GbYHsoln98LVTuaojuX9IqIQZvBo/6E631FfMfArbLxkbNn8QtnwlzIKA==", "X-Received": "by 2002:a05:6402:b85:: with SMTP id\n\tcf5mr42025200edb.248.1615975341945; \n\tWed, 17 Mar 2021 03:02:21 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 17 Mar 2021 10:02:09 +0000", "Message-Id": "<20210317100211.1067585-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210317100211.1067585-1-naush@raspberrypi.com>", "References": "<20210317100211.1067585-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/7] ipa: raspberrypi: Remove unused\n\tmember variables", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the recent refactoring of code from ipa::configure() to ipa::init()\nsome member variable are now unused, so remove them.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex e2db0716b84b..2ca64bcdb80a 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -67,8 +67,7 @@ class IPARPi : public ipa::RPi::IPARPiInterface\n {\n public:\n \tIPARPi()\n-\t\t: lastMode_({}), controller_(), controllerInit_(false),\n-\t\t frameCount_(0), checkCount_(0), mistrustCount_(0),\n+\t\t: controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0),\n \t\t lsTable_(nullptr), firstStart_(true)\n \t{\n \t}\n@@ -129,12 +128,10 @@ private:\n \n \t/* Camera sensor params. */\n \tCameraMode mode_;\n-\tCameraMode lastMode_;\n \n \t/* Raspberry Pi controller specific defines. */\n \tstd::unique_ptr<RPiController::CamHelper> helper_;\n \tRPiController::Controller controller_;\n-\tbool controllerInit_;\n \tRPiController::Metadata rpiMetadata_;\n \n \t/*\n@@ -387,8 +384,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo,\n \t\tresult->controls = std::move(ctrls);\n \t}\n \n-\tlastMode_ = mode_;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "5/7" ] }