Patch Detail
Show a patch.
GET /api/1.1/patches/11588/?format=api
{ "id": 11588, "url": "https://patchwork.libcamera.org/api/1.1/patches/11588/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11588/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210316144711.40778-4-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-03-16T14:47:11", "name": "[libcamera-devel,v3,3/3] libcamera: ipu3: Pass the BDS rectangle at IPA configure call", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a26bc3eca731ad95f43751bfdf0f4bb591e825a", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11588/mbox/", "series": [ { "id": 1796, "url": "https://patchwork.libcamera.org/api/1.1/series/1796/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1796", "date": "2021-03-16T14:47:08", "name": "Prepare IPU3 pipeline to pass BDS to IPA", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1796/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11588/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11588/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A68F5C32E2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Mar 2021 14:47:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49D6968D57;\n\tTue, 16 Mar 2021 15:47:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DA8868D4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Mar 2021 15:47:24 +0100 (CET)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16DC28C8;\n\tTue, 16 Mar 2021 15:47:24 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nUvhgFZ1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615906044;\n\tbh=Nx0KwrE+Le+uO0UpwsTZcT2BoR1LGMbwJXe2nAogpYg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nUvhgFZ1UkreZOW4fYG3gKp7H7gbSDoOzUNVm0blfAoObSpx1b59MlO+mC1c9119z\n\tP5aH8swxPYQtUt8AsRQWdEaYnCldwzkOTXc9JiN4qaKqNrYqu9jjaC1stxuQvKovYR\n\tPzdvuTWfwTmyekWtsxmLtFym+LoZhvJcqsVtDnVo=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Mar 2021 15:47:11 +0100", "Message-Id": "<20210316144711.40778-4-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210316144711.40778-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210316144711.40778-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 3/3] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\nwill be integrated.\nIn order to do that, the configure() interface needs to be modified.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nv3:\n- pass bds size to ipa->configure()\nv2:\n- rename bds => bdsOutputSize\n- use a libcamera::Size instead of libcamera::Rectangle\n---\n include/libcamera/ipa/ipu3.mojom | 2 +-\n src/ipa/ipu3/ipu3.cpp | 7 +++++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex 6ee11333..5d13e7ea 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n \tstart() => (int32 ret);\n \tstop();\n \n-\tconfigure(map<uint32, ControlInfoMap> entityControls) => ();\n+\tconfigure(map<uint32, ControlInfoMap> entityControls, Size bdsOutputSize) => ();\n \n \tmapBuffers(array<IPABuffer> buffers);\n \tunmapBuffers(array<uint32> ids);\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b63e58be..be73a225 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -35,7 +35,9 @@ public:\n \tint start() override { return 0; }\n \tvoid stop() override {}\n \n-\tvoid configure(const std::map<uint32_t, ControlInfoMap> &entityControls) override;\n+\tvoid configure(\n+\t\tconst std::map<uint32_t, ControlInfoMap> &entityControls,\n+\t\tconst Size &bdsOutputSize) override;\n \n \tvoid mapBuffers(const std::vector<IPABuffer> &buffers) override;\n \tvoid unmapBuffers(const std::vector<unsigned int> &ids) override;\n@@ -62,7 +64,8 @@ private:\n \tuint32_t maxGain_;\n };\n \n-void IPAIPU3::configure(const std::map<uint32_t, ControlInfoMap> &entityControls)\n+void IPAIPU3::configure(const std::map<uint32_t, ControlInfoMap> &entityControls,\n+\t\t\t[[maybe_unused]] const Size &bdsOutputSize)\n {\n \tif (entityControls.empty())\n \t\treturn;\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 174c1dd8..dcc6ad22 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -633,7 +633,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \n \tstd::map<uint32_t, ControlInfoMap> entityControls;\n \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n-\tdata->ipa_->configure(entityControls);\n+\tdata->ipa_->configure(entityControls, config->pipeConfig_.bds);\n \n \treturn 0;\n }\n", "prefixes": [ "libcamera-devel", "v3", "3/3" ] }