Patch Detail
Show a patch.
GET /api/1.1/patches/11572/?format=api
{ "id": 11572, "url": "https://patchwork.libcamera.org/api/1.1/patches/11572/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11572/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210313100218.2872534-1-naush@raspberrypi.com>", "date": "2021-03-13T10:02:18", "name": "[libcamera-devel] libcamera: delayed_controls: Add missing documentation for ControlParams", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "29ff7266a3f677b49cfbbfd1e89f7a6112a6bbf2", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11572/mbox/", "series": [ { "id": 1788, "url": "https://patchwork.libcamera.org/api/1.1/series/1788/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1788", "date": "2021-03-13T10:02:18", "name": "[libcamera-devel] libcamera: delayed_controls: Add missing documentation for ControlParams", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1788/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11572/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11572/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3569BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 13 Mar 2021 10:02:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47E4E605B2;\n\tSat, 13 Mar 2021 11:02:29 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA221602E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Mar 2021 11:02:27 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id\n\tr10-20020a05600c35cab029010c946c95easo16555960wmq.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Mar 2021 02:02:27 -0800 (PST)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tc11sm12116333wrm.67.2021.03.13.02.02.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 13 Mar 2021 02:02:26 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"t28/uzBS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=pLcOs/U6hdvmvqiKyFjlkzc9xuf8WSi8IGrLCbr8YNs=;\n\tb=t28/uzBSeks9JuvC/ZDonmyTr227jU3eQ/x8VR2WZQhdoPmv7rAz2mszEZ3+3anQfS\n\tOvY6gQoB7zurU8hrv/rn3V9n5BujKVtybw1XcJ7vX7/1IWuSeQ8WzmzRNEhuw9sNoSYT\n\tYodru003fenaqaDV3X+aMou80RFy4uW9HuHBlk/p8688WfDz5LvL0zNkPqVu64QMw8a3\n\tJCC+hLC6Pb6JGNyrHj/RifnU40yxklCirH8Xe8W6w727KV9hqkFHNA0G08hqyV0Zijzo\n\t6LlRq/9qHzsm9QtJI7XR2Qk4j0slGWqqBAq4vLJ+Z5FI76mCiT87u/yQojUxjtDZIwJT\n\tADAw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=pLcOs/U6hdvmvqiKyFjlkzc9xuf8WSi8IGrLCbr8YNs=;\n\tb=U6tpHotOrVic51T4uPIP7BaZ4Wq2JfT2Ag8zlCnW+DmanB61Ii4hFz/le2k/m8OZah\n\tDX12zKxhwu/QncrKg2D+Pq8Hn/Vp7Y2Ut7hf/8pKH7OcvZKxKQyS2ZEL9ZCTQDVIYXAi\n\tsh5Vb7voMKsYVoeyxVBG1vVGtl+SF25wM02pdTbUPDgDF4dQG/nQ/BCg0ekk1kcVpwwk\n\tyzX4YEnWGvsTH+RyiQAxqRgGZ89C/mLvffR0UmgbZAWpE1KHpyiH/v96fmI3UWldx44Y\n\tJyyYTyQ67TwTSRj/q4W8f2WVokJ71Qmh86vIY9wCqpfslYizfSYk1MZzelom+IuQnw8v\n\tvSgQ==", "X-Gm-Message-State": "AOAM5321PwR2Ve7z3NB1Zs4M50lCKGtDOtdYqSlRUJa2j6VgJ/qSUy8E\n\t4x2uLmhxhHjabu1N7a8Ypf9AR4oRItYNkQ==", "X-Google-Smtp-Source": "ABdhPJxhKz9r7Z6NBQlup51UsHxyUmT46l1HA4zZ0z8J8qY+BWPyjVAjI3omyxwkXscx65VocSkL9A==", "X-Received": "by 2002:a7b:c0c4:: with SMTP id s4mr17627337wmh.9.1615629747013; \n\tSat, 13 Mar 2021 02:02:27 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 13 Mar 2021 10:02:18 +0000", "Message-Id": "<20210313100218.2872534-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: delayed_controls: Add missing\n\tdocumentation for ControlParams", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Document struct DelayedControls::ControlParams and its associated\nfields.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/delayed_controls.cpp | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex a3917fd99e7a..0f70d087b22c 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -37,6 +37,23 @@ LOG_DEFINE_CATEGORY(DelayedControls)\n * delay.\n */\n \n+/**\n+ * \\struct DelayedControls::ControlParams\n+ * \\brief Parameters associated with controls handled by the \\a DelayedControls\n+ * helper class\n+ *\n+ * \\var ControlParams::delay\n+ * \\brief Frame delay from setting the control on a sensor device to when it is\n+ * consumed during framing.\n+ *\n+ * \\var ControlParams::priorityWrite\n+ * \\brief Flag to indicate that this control must be applied\n+ * ahead of, and separately from the other controls. Typically set for the \\a\n+ * V4L2_CID_VBLANK control so that the device driver does not reject \\a\n+ * V4L2_CID_EXPOSURE control values that may be outside of the existing vertical\n+ * blanking specified bounds, but are within the new blanking bounds.\n+ */\n+\n /**\n * \\brief Construct a DelayedControls instance\n * \\param[in] device The V4L2 device the controls have to be applied to\n", "prefixes": [ "libcamera-devel" ] }