Patch Detail
Show a patch.
GET /api/1.1/patches/11566/?format=api
{ "id": 11566, "url": "https://patchwork.libcamera.org/api/1.1/patches/11566/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11566/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210312061131.854849-7-kieran.bingham@ideasonboard.com>", "date": "2021-03-12T06:11:29", "name": "[libcamera-devel,6/8] libcamera: pipeline: ipu3: frames: Group FrameBuffer operations", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b50ebb0a432c4d41d1394bcb377c284655fc7483", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11566/mbox/", "series": [ { "id": 1786, "url": "https://patchwork.libcamera.org/api/1.1/series/1786/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1786", "date": "2021-03-12T06:11:23", "name": "IPU3 Debug improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1786/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11566/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11566/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63DDCBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Mar 2021 06:11:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11BA868C75;\n\tFri, 12 Mar 2021 07:11:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F89268C76\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Mar 2021 07:11:38 +0100 (CET)", "from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C581588F;\n\tFri, 12 Mar 2021 07:11:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uJ9B4kQd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615529498;\n\tbh=BmNdLAWejPuHrU3gWw6s6ZHjwSS7pi1sF0vPBIL1VBc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uJ9B4kQdE4xbASQ4TWx1is0C8HBbJo0KZKbps0J9XXEh9Kjb6MLzi+ipQlr9qkefk\n\tlfD8wNfiTY8gT5EjRsuHCP/g+Fko7r5RshJVk8/vDNeF5V8y/GsUf7axNoie3E35Zc\n\t6WVRrqkp+mB6PK0oW27zZ5QLZWMxSRUYuB4kbSH4=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 12 Mar 2021 06:11:29 +0000", "Message-Id": "<20210312061131.854849-7-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "References": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 6/8] libcamera: pipeline: ipu3: frames:\n\tGroup FrameBuffer operations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Ensure that checks on resource availability are handled first, and then\noperate on the queues only after the resources are confirmed as\navailable.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/frames.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex b8b471c3c561..7a7c5643df43 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -47,12 +47,13 @@ IPU3Frames::Info *IPU3Frames::create(Request *request)\n \t\tLOG(IPU3, Error) << \"Parameters buffer underrun\";\n \t\treturn nullptr;\n \t}\n-\tFrameBuffer *paramBuffer = availableParamBuffers_.front();\n \n \tif (availableStatBuffers_.empty()) {\n \t\tLOG(IPU3, Error) << \"Statistics buffer underrun\";\n \t\treturn nullptr;\n \t}\n+\n+\tFrameBuffer *paramBuffer = availableParamBuffers_.front();\n \tFrameBuffer *statBuffer = availableStatBuffers_.front();\n \n \tavailableParamBuffers_.pop();\n", "prefixes": [ "libcamera-devel", "6/8" ] }