Patch Detail
Show a patch.
GET /api/1.1/patches/11562/?format=api
{ "id": 11562, "url": "https://patchwork.libcamera.org/api/1.1/patches/11562/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11562/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210312061131.854849-3-kieran.bingham@ideasonboard.com>", "date": "2021-03-12T06:11:25", "name": "[libcamera-devel,2/8] libcamera: request: Add a toString()", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "7395ccbcb65848c5d6587e14c754dd34124d5ced", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11562/mbox/", "series": [ { "id": 1786, "url": "https://patchwork.libcamera.org/api/1.1/series/1786/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1786", "date": "2021-03-12T06:11:23", "name": "IPU3 Debug improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1786/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11562/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11562/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9451BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Mar 2021 06:11:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D875F68C7D;\n\tFri, 12 Mar 2021 07:11:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9627D602ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Mar 2021 07:11:36 +0100 (CET)", "from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24C90A27;\n\tFri, 12 Mar 2021 07:11:36 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ab7X32Wt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615529496;\n\tbh=mio3TBRsq6S1QTk5nncX/izBn0dtYPYRAfyfChvig+8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ab7X32Wt8gyxiNjYs80uR9YqC5EY9h0u49gTGAYg+d5NnIMIImS9/AYldjexE/81a\n\tqZqL1NiFrnDIopmujSp331pg8o/jgJHNegbdgwMVP+t4y+oWM7c8WXkeLt/i2CbqKb\n\tYjrFzMQ5XPcnvVHDEVVI1F1+Wq+iJEnFsyEqI7E8=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 12 Mar 2021 06:11:25 +0000", "Message-Id": "<20210312061131.854849-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "References": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/8] libcamera: request: Add a toString()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide a toString helper to assist in printing Request state\nfor debug and logging contexts.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/request.h | 2 ++\n src/libcamera/request.cpp | 20 +++++++++++++++++++-\n 2 files changed, 21 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 6f2f881e840a..59d7f4bac0d2 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -56,6 +56,8 @@ public:\n \n \tbool hasPendingBuffers() const { return !pending_.empty(); }\n \n+\tconst std::string toString() const;\n+\n private:\n \tLIBCAMERA_DISABLE_COPY(Request)\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 24c3694de5fc..12c2e7d425f9 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -268,7 +268,7 @@ void Request::complete()\n \tstatus_ = cancelled_ ? RequestCancelled : RequestComplete;\n \n \tLOG(Request, Debug)\n-\t\t<< \"Request has completed - cookie: \" << cookie_\n+\t\t<< toString() << \" has completed - cookie: \" << cookie_\n \t\t<< (cancelled_ ? \" [Cancelled]\" : \"\");\n \n \tLIBCAMERA_TRACEPOINT(request_complete, this);\n@@ -302,4 +302,22 @@ bool Request::completeBuffer(FrameBuffer *buffer)\n \treturn !hasPendingBuffers();\n }\n \n+const std::string Request::toString() const\n+{\n+\tstd::stringstream ss;\n+\n+\tstatic const char *statuses[] = {\n+\t\t\"Pending\",\n+\t\t\"Complete\",\n+\t\t\"Cancelled\",\n+\t};\n+\n+\tss << \"Request (\" << sequence_ << \") \" << statuses[status_];\n+\n+\tif (hasPendingBuffers())\n+\t\tss << \" [Pending:\" << pending_.size() << \"]\";\n+\n+\treturn ss.str();\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "2/8" ] }