Patch Detail
Show a patch.
GET /api/1.1/patches/11553/?format=api
{ "id": 11553, "url": "https://patchwork.libcamera.org/api/1.1/patches/11553/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11553/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210312054727.852622-3-kieran.bingham@ideasonboard.com>", "date": "2021-03-12T05:47:21", "name": "[libcamera-devel,v2,2/8] utils: ipc: proxy: Process pending messages", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a1cf3716cc7907c1ed370f001cb752f6a9cfd5df", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11553/mbox/", "series": [ { "id": 1785, "url": "https://patchwork.libcamera.org/api/1.1/series/1785/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1785", "date": "2021-03-12T05:47:19", "name": "IPU3 Stability", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1785/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11553/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11553/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 858DCBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Mar 2021 05:47:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34F5968C75;\n\tFri, 12 Mar 2021 06:47:35 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56ABA605B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Mar 2021 06:47:32 +0100 (CET)", "from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD37EA27;\n\tFri, 12 Mar 2021 06:47:31 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aLppM0HY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528052;\n\tbh=PJh67ciDzElBE6OaDdXhg8fX+IPxGjewNSScBfLTJIM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aLppM0HYFD/gQW1k5Oxi0mFbHLbY+TmVUs73WHT9wRYWYL9niRQwKhur735Zj2cvc\n\t8uhmoX30th7zQabfxKW4i4PkY6AybRy4Ugl4kUndV2CtIT+DprfTIDSQqrRJu40kKZ\n\tz1gpzvG6Tm3ERyDOaEjxtLhYARb0Vi5KoU9iZVfc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 12 Mar 2021 05:47:21 +0000", "Message-Id": "<20210312054727.852622-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210312054727.852622-1-kieran.bingham@ideasonboard.com>", "References": "<20210312054727.852622-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/8] utils: ipc: proxy: Process pending\n\tmessages", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nEvents may be queued to the pipeline handler between the pipeline\nhandler entering the ::stop() function, and before the call to stop the\nIPA has completed.\n\nHandle these events by dispatching all pending messages at the proxy\nafter the IPA has fully stopped.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\nindex 13dc8fdcab6e..8addc2fad0a8 100644\n--- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n@@ -31,6 +31,8 @@\n \tthread_.exit();\n \tthread_.wait();\n \n+\tThread::current()->dispatchMessages(Message::Type::InvokeMessage);\n+\n \trunning_ = false;\n {%- endmacro -%}\n \n", "prefixes": [ "libcamera-devel", "v2", "2/8" ] }