Patch Detail
Show a patch.
GET /api/1.1/patches/11549/?format=api
{ "id": 11549, "url": "https://patchwork.libcamera.org/api/1.1/patches/11549/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11549/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210311205255.741985-2-nicolas@ndufresne.ca>", "date": "2021-03-11T20:52:54", "name": "[libcamera-devel,1/2] gst: provider: Fix crash in finalize", "commit_ref": "488bbe40a9183a6061e4e3fc975d8e289c6f75ac", "pull_url": null, "state": "accepted", "archived": false, "hash": "50b390cd0e25c6226265ef2e71d1062515a532ee", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/1.1/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11549/mbox/", "series": [ { "id": 1784, "url": "https://patchwork.libcamera.org/api/1.1/series/1784/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1784", "date": "2021-03-11T20:52:53", "name": "GStreamer Fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1784/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11549/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11549/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAF27BD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Mar 2021 20:53:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AB6368C6E;\n\tThu, 11 Mar 2021 21:53:09 +0100 (CET)", "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D6FF602E8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Mar 2021 21:53:08 +0100 (CET)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id AAD891F466FC" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Mar 2021 15:52:54 -0500", "Message-Id": "<20210311205255.741985-2-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210311205255.741985-1-nicolas@ndufresne.ca>", "References": "<20210311205255.741985-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] gst: provider: Fix crash in finalize", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>, kernel@collabora.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nBoth the DeviceProvider and Device classes had the same mistake,\ncalling G_OBJECT_GET_CLASS() instead of G_OBJECT_CLASS() when\nchaining their finalize call to their base class. This would\ncrash at destruction, which was causing gst-device-monitor-1.0\ntool to crash and application using that API to crash too.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcameraprovider.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex ee44dc73..29da6c32 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -101,7 +101,7 @@ gst_libcamera_device_finalize(GObject *object)\n \n \tg_free(self->name);\n \n-\tG_OBJECT_GET_CLASS(klass)->finalize(object);\n+\tG_OBJECT_CLASS(klass)->finalize(object);\n }\n \n static void\n@@ -218,7 +218,7 @@ gst_libcamera_provider_finalize(GObject *object)\n \n \tdelete self->cm;\n \n-\treturn G_OBJECT_GET_CLASS(klass)->finalize(object);\n+\treturn G_OBJECT_CLASS(klass)->finalize(object);\n }\n \n static void\n", "prefixes": [ "libcamera-devel", "1/2" ] }