Patch Detail
Show a patch.
GET /api/1.1/patches/11534/?format=api
{ "id": 11534, "url": "https://patchwork.libcamera.org/api/1.1/patches/11534/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11534/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210309085235.106691-4-paul.elder@ideasonboard.com>", "date": "2021-03-09T08:52:34", "name": "[libcamera-devel,v2,3/4] android: jpeg: exif: Fix setGPSLocation longitude", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "59c32eea074c8c6f58d664d70b4f64574477d427", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11534/mbox/", "series": [ { "id": 1776, "url": "https://patchwork.libcamera.org/api/1.1/series/1776/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1776", "date": "2021-03-09T08:52:31", "name": "android: jpeg: exif: Fix GPS altitude", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1776/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11534/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11534/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D04E8BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 9 Mar 2021 08:52:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8417668AA8;\n\tTue, 9 Mar 2021 09:52:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6597468AA8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Mar 2021 09:52:53 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56B54E9;\n\tTue, 9 Mar 2021 09:52:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tdibM1Xt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615279973;\n\tbh=2NWnuGYHN3lnxeDsUgtdtfmwU59ERSvgp7s+88w3+zs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tdibM1XtEOL26q/sibknbDUHH0QKHFI+tpMT4tJPCJT87Ngsj4iRH2vCaeB19ARnt\n\tgDaXZU0kEFpsgTJg13eU0oWl93uPcJM8D/v5MDhDriXwO9avXmaPp/1t58mzShwejL\n\taV1QhT4Cvj63wjwx4/0Qv4sZAyaRh6Bls/hvl1f4=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 9 Mar 2021 17:52:34 +0900", "Message-Id": "<20210309085235.106691-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210309085235.106691-1-paul.elder@ideasonboard.com>", "References": "<20210309085235.106691-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/4] android: jpeg: exif: Fix\n\tsetGPSLocation longitude", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There was a copy-paste error that caused the latitude to be set twice and\nthe longitude never. Fix this.\n\nThis is part of the fix that allows the following CTS test to pass:\n- android.hardware.cts.CameraTest#testJpegExif\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v2\n---\n src/android/jpeg/exif.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex cf9e632a..628382a9 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -395,7 +395,7 @@ void Exif::setGPSLocation(const double *coords)\n \tstd::tie<int, int, int>(deg, min, sec) = degreesToDMS(coords[1]);\n \tsetString(EXIF_IFD_GPS, static_cast<ExifTag>(EXIF_TAG_GPS_LONGITUDE_REF),\n \t\t EXIF_FORMAT_ASCII, deg >= 0 ? \"E\" : \"W\");\n-\tsetGPSDMS(EXIF_IFD_GPS, static_cast<ExifTag>(EXIF_TAG_GPS_LATITUDE),\n+\tsetGPSDMS(EXIF_IFD_GPS, static_cast<ExifTag>(EXIF_TAG_GPS_LONGITUDE),\n \t\t std::abs(deg), min, sec);\n \n \tsetByte(EXIF_IFD_GPS, static_cast<ExifTag>(EXIF_TAG_GPS_ALTITUDE_REF),\n", "prefixes": [ "libcamera-devel", "v2", "3/4" ] }