Patch Detail
Show a patch.
GET /api/1.1/patches/11467/?format=api
{ "id": 11467, "url": "https://patchwork.libcamera.org/api/1.1/patches/11467/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11467/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210302155041.110853-1-kieran.bingham@ideasonboard.com>", "date": "2021-03-02T15:50:41", "name": "[libcamera-devel] tracing: pipeline_handler: Queue Requests", "commit_ref": "a36cde7834c114fd14ef07781742b5aa25d0b5d9", "pull_url": null, "state": "accepted", "archived": false, "hash": "489a0cbbf1155d7d3b51f6b5c6395206034a18b1", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11467/mbox/", "series": [ { "id": 1744, "url": "https://patchwork.libcamera.org/api/1.1/series/1744/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1744", "date": "2021-03-02T15:50:41", "name": "[libcamera-devel] tracing: pipeline_handler: Queue Requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1744/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11467/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11467/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6D56BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Mar 2021 15:50:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CC7568A98;\n\tTue, 2 Mar 2021 16:50:47 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D240B68A7E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Mar 2021 16:50:45 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4845F45D;\n\tTue, 2 Mar 2021 16:50:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PRZLKbzO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614700245;\n\tbh=SNmP5byYXH7n+s5J78tSJLGXbr0stllxhHAscERxQBY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=PRZLKbzOSA3wqooNYEN5A0MiEB9vHYd8ACAHXChriVeS+ztclemMFM44WxZsMNyxe\n\tVI7vYM6lIvvDqiryrJGKIu58hQ5QTul7XMZMmsVKqVenskVn8iswJg8SbD1K4n1XGh\n\tyzR/uuCGWQmLK3ikeT4JE2L2GZaX2vH7YVpLTX+w=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 2 Mar 2021 15:50:41 +0000", "Message-Id": "<20210302155041.110853-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] tracing: pipeline_handler: Queue Requests", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add tracing to the base pipeline handler class to track when requests are queued.\n\nTracing is already available for other Request operations, but queuing a Request\nis not an operation handled by the Request itself.\n\nAdd the tracepoint to the PipelineHandler::queueRequest() so the lifetime of a\nRequest can be viewed when tracing.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/tracepoints/request.tp | 9 +++++++++\n src/libcamera/pipeline_handler.cpp | 3 +++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex 7ffc606182f6..9e872951374d 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -48,6 +48,15 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n+TRACEPOINT_EVENT_INSTANCE(\n+\tlibcamera,\n+\trequest,\n+\trequest_queue,\n+\tTP_ARGS(\n+\t\tlibcamera::Request *, req\n+\t)\n+)\n+\n TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n \trequest,\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex f72d26c793cd..d22991d318c9 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -16,6 +16,7 @@\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/log.h\"\n #include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/tracepoints.h\"\n #include \"libcamera/internal/utils.h\"\n \n /**\n@@ -375,6 +376,8 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n */\n int PipelineHandler::queueRequest(Request *request)\n {\n+\tLIBCAMERA_TRACEPOINT(request_queue, request);\n+\n \tCamera *camera = request->camera_;\n \tCameraData *data = cameraData(camera);\n \tdata->queuedRequests_.push_back(request);\n", "prefixes": [ "libcamera-devel" ] }