Patch Detail
Show a patch.
GET /api/1.1/patches/11446/?format=api
{ "id": 11446, "url": "https://patchwork.libcamera.org/api/1.1/patches/11446/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11446/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210302122341.83985-3-kieran.bingham@ideasonboard.com>", "date": "2021-03-02T12:23:41", "name": "[libcamera-devel,2/2] libcamera: pipeline_handler: Update request usage comment", "commit_ref": "8c81ab298eb19541bb7a37db5a34434c23a8a18d", "pull_url": null, "state": "accepted", "archived": false, "hash": "af47d8b597877cdd17fc1323786093703161ed20", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11446/mbox/", "series": [ { "id": 1739, "url": "https://patchwork.libcamera.org/api/1.1/series/1739/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1739", "date": "2021-03-02T12:23:39", "name": "libcamera: Request: Catch double completions", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1739/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11446/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11446/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9609BD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Mar 2021 12:23:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AC6268AA5;\n\tTue, 2 Mar 2021 13:23:47 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07D3768A98\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Mar 2021 13:23:46 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9874EFE0;\n\tTue, 2 Mar 2021 13:23:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eVjSWvjW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614687825;\n\tbh=TGB0glKg659i3z6GT7Bz2IJOucy67Q9UY2eK7Gg31BY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eVjSWvjWDt89/HiKbUZ401scyDxuOXpA+8eRicAHb9+4zF5OazllVAPzb/vE8Lpo3\n\tHIe0vWzIbzh7xE3qrNj20endwbynnF+IzQShQwQH6ouxSqg7SLecASKHnw6nwKg8Ga\n\t0EwHVQWjXb+sZWTnOrbUgLA7/7iiJzkmgCjSiIyg=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 2 Mar 2021 12:23:41 +0000", "Message-Id": "<20210302122341.83985-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210302122341.83985-1-kieran.bingham@ideasonboard.com>", "References": "<20210302122341.83985-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler: Update\n\trequest usage comment", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a pipeline handler completes a request, the request itself is not\ndeleted by libcamera, and the application regains control over the\nobject. It may choose to delete the Request, or re-use it.\n\nClarify this in the comment by removing the declaration that the Request\nis deleted, but state that it is no longer managed by the pipeline\nhandler and must not be accessed further after this function returns.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex aff83af2e90e..0255d9476de0 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n * \\param[in] request The request that has completed\n *\n * The pipeline handler shall call this method to notify the \\a camera that the\n- * request has completed. The request is deleted and shall not be accessed once\n- * this method returns.\n+ * request has completed. The request is no longer managed by the pipeline\n+ * handler and shall not be accessed once this method returns.\n *\n * This method ensures that requests will be returned to the application in\n * submission order, the pipeline handler may call it on any complete request\n", "prefixes": [ "libcamera-devel", "2/2" ] }