Patch Detail
Show a patch.
GET /api/1.1/patches/11417/?format=api
{ "id": 11417, "url": "https://patchwork.libcamera.org/api/1.1/patches/11417/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11417/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210301133159.4179129-6-naush@raspberrypi.com>", "date": "2021-03-01T13:31:59", "name": "[libcamera-devel,v3,5/5] libcamera: delayed_controls: Fix off-by-one error in get()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "43f54ada86bb75fed69c13b33c2f7b03fb5b1445", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11417/mbox/", "series": [ { "id": 1734, "url": "https://patchwork.libcamera.org/api/1.1/series/1734/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1734", "date": "2021-03-01T13:31:54", "name": "DelayedControls updates and fixes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1734/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11417/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11417/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A47EBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Mar 2021 13:32:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 638A468AA0;\n\tMon, 1 Mar 2021 14:32:13 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0896168A99\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Mar 2021 14:32:12 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id u187so11613937wmg.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 01 Mar 2021 05:32:12 -0800 (PST)", "from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\ta75sm11263630wme.10.2021.03.01.05.32.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Mar 2021 05:32:10 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"nEf5DyvX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Dphl3ZTsb6BZ6uAfpHD339RxAaUTr2aTC087IdEwZ2k=;\n\tb=nEf5DyvXtRCSH+CaFrpaZxtRn3jZ45GLXAaOHf8o/TyKWkS6j155Mpk6Tae+0qjBfu\n\tN1QM2GOT7nywzcexRwHzmyY9Dp0UNNGNGwNcwHDp7OOzOszAFPxsx1AtVriHdlL1sj5i\n\t6AvjSmbi+gAvPB+U5gPG0kWIKarUcEPASS7/lS/2NV68ANZ1pqP/m8DuqiU1nO7jsr9A\n\tWG8qqPwoheMfO/Hu2ybfUrS0+/ZpJBzymPC8titv69M5qzZ1ObylBW1kmtUM1aAuFDxP\n\twrYwVWMTt3A/ymx3b6SRYculJA8Mvp761n3GcDlFyTZ8u15JIljzKmeJTgWPU04Sj+77\n\tOAqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Dphl3ZTsb6BZ6uAfpHD339RxAaUTr2aTC087IdEwZ2k=;\n\tb=h9A3jMx4uDyrEqer5sSZjoH/1lClHHR52DXtemJf34/EKMnbQZfS0+kg0PQ7Fe5m7w\n\tmUvE/C7QQO+wUUWwz5sKiDMJ7SBc5zHcHC15HubZins+zpNpxa8yWjuq3OD4ewcv6cjF\n\t3QV/3Ols0wct7fxrc+mpljTbo7CyuwJSviZo4IWSt/UinXD6OipEnoj1MvnnGqD5ubRV\n\tK/NGt1I5vpPFLdjnkCmTLKAh2TbTq+sm5vlgKjgBLsFu6LRahCSbiy6n+NvadY3981n3\n\tDARrKFt/ES036gxdbeaCZ5a+Xe+cQ/nKAWVpKJfg0RPNOwVm6Y1h2YQ9X90F4AznOn6i\n\tesyw==", "X-Gm-Message-State": "AOAM530QBn0YsTLxZOf/hMbwgIGzDt7jx/V8osoZRfAlReG6TAkaXSpF\n\tydi4Wu+hBCaN9V2xmW8zIpb5T6Ln3AVQZeXd", "X-Google-Smtp-Source": "ABdhPJzDt83Mjb+7T568NBcrAuKworhKkgqfYsnkZkaYkRL1kYbSf/kg6Ev2q3JZsNITupikbIiIHg==", "X-Received": "by 2002:a1c:7415:: with SMTP id\n\tp21mr5718031wmc.187.1614605530819; \n\tMon, 01 Mar 2021 05:32:10 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 1 Mar 2021 13:31:59 +0000", "Message-Id": "<20210301133159.4179129-6-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210301133159.4179129-1-naush@raspberrypi.com>", "References": "<20210301133159.4179129-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 5/5] libcamera: delayed_controls: Fix\n\toff-by-one error in get()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There was an off-by-one error in DelayedControls::get() when picking\ncontrols from the queue to return back to the pipeline handler.\nThis is only noticeable as small oscillations in brightness when closely\nviewing frame while AGC is running. The old StaggeredCtrl did not show\nthis error as the startup queuing mechanism has changed in\nDelayedControls.\n\nFix this by indexing to the correct position in the queue.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReported-by: David Plowman <david.plowman@raspberrypi.com>\nFixes: 3d4b7b005911 (\"libcamera: delayed_controls: Add helper for controls that apply with a delay\")\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/delayed_controls.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 5a05741c0285..138761c9852e 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -184,7 +184,7 @@ bool DelayedControls::push(const ControlList &controls)\n */\n ControlList DelayedControls::get(uint32_t sequence)\n {\n-\tuint32_t adjustedSeq = sequence - firstSequence_ + 1;\n+\tuint32_t adjustedSeq = sequence - firstSequence_;\n \tunsigned int index = std::max<int>(0, adjustedSeq - maxDelay_);\n \n \tControlList out(device_->controls());\n", "prefixes": [ "libcamera-devel", "v3", "5/5" ] }