Patch Detail
Show a patch.
GET /api/1.1/patches/11331/?format=api
{ "id": 11331, "url": "https://patchwork.libcamera.org/api/1.1/patches/11331/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11331/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210218124824.1825418-2-naush@raspberrypi.com>", "date": "2021-02-18T12:48:21", "name": "[libcamera-devel,v3,1/4] pipeline: ipa: raspberrypi: Fix pipeline running on in a stopped state", "commit_ref": "a13d229086d73bcde4c0204d359e2352de4fdbdf", "pull_url": null, "state": "accepted", "archived": false, "hash": "25dc90ac9413f872a0125542785bf12e124e0144", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11331/mbox/", "series": [ { "id": 1706, "url": "https://patchwork.libcamera.org/api/1.1/series/1706/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1706", "date": "2021-02-18T12:48:20", "name": "Updates after IPAInterface changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1706/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11331/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11331/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37186BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Feb 2021 12:48:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE4C0689B3;\n\tThu, 18 Feb 2021 13:48:34 +0100 (CET)", "from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5911F68110\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Feb 2021 13:48:33 +0100 (CET)", "by mail-wr1-x434.google.com with SMTP id f7so1686965wrt.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Feb 2021 04:48:33 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:15:c37b:2722:9ed2:1d58])\n\tby smtp.gmail.com with ESMTPSA id\n\tz63sm7675876wme.8.2021.02.18.04.48.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Feb 2021 04:48:32 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"tvAsibqV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=BxgoKMN/TClcFlvFt8c9k+4ExYPEZI7X8fMcpxmrXJw=;\n\tb=tvAsibqVXRDQgZcO7iB2zHvE429SQP/db8y5X/g/i8+Hr7sY+XquiRS/4LXFi1i3HZ\n\tpibpYu2CsSZQSt4/jtib2t3UpvfKbbzYzSdtb3JrkZWM3FB9WiSCy8JXQD0HMp+ZgAAz\n\tPi1y2b2HWXV/YO69XT8T2NbfpABuhTreMPSPf1M+Yf2Ysf8FVM4Qivcol0rYzapOtZ9O\n\tWbHO+7bZ7wr1ep+h+6tP1YmBD9eGfJNcGgEuF2d06kSVDvCg9pxU97uKie1zLYsdBose\n\tskqAjD6nwvISEnJU0gaEq8fo3bMAJEmG3oSwKkCzYqK+sLaiEr5pykRbNeOOnrSfjRtz\n\teHKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=BxgoKMN/TClcFlvFt8c9k+4ExYPEZI7X8fMcpxmrXJw=;\n\tb=ikGGJJvucFFsh7myGb4DUtroZESSEZXVb6zPNu1QONAykGHZo54a7Mtz9Xeaga7YD7\n\t/kw3ixXpGUF/FsISXsEhWy/Z5nXF1b6jefLS2evXyr6JmwjuiyKC+dIZN5jn5/cXrB9b\n\tjdzto6Bp4uk7OxTErwdhVE+p3fftR06FvdhZBBhAb7lpkJnZDEAFY26w4dKwRyvtU/dS\n\tLFLA7Nj2kqe1jGf5T+ZE1l/vB9rQDVGgCpeO3FBzTJFxr+6QS9wGo02kNcRRzc4+MOSn\n\t9gqWZpenEfX1nOtQfr9ZxBJbgzQOQ0TjzzAniFOT4dudMRGQt0d7FulYpNBiWeVwLGf1\n\tw07w==", "X-Gm-Message-State": "AOAM5326oIi+16bf6U76poTr04djAGfF8lcYj1XmVd0P5t4MZuniXufU\n\tFQm/gJyK8kMQkqD6TPgcxovUi9ippvidQRrE", "X-Google-Smtp-Source": "ABdhPJzeHhvgr2ZI0iXyAJqklT9K78KXUZsApJh8SyU94Uf74L/yS3/9F6JEv1sA65BNilcOO4Db4g==", "X-Received": "by 2002:adf:ebcb:: with SMTP id\n\tv11mr4112543wrn.231.1613652512820; \n\tThu, 18 Feb 2021 04:48:32 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 18 Feb 2021 12:48:21 +0000", "Message-Id": "<20210218124824.1825418-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210218124824.1825418-1-naush@raspberrypi.com>", "References": "<20210218124824.1825418-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 1/4] pipeline: ipa: raspberrypi: Fix\n\tpipeline running on in a stopped state", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the recent IPAInterface changes, the signal handlers\nstatsMetadataComplete(), runISP() and embeddedComplete() would run\nunconditionally when called. They should only run when state != Stopped.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nFixes: e201cb4f5450 (\"libcamera: IPAInterface: Replace C API with the new C++-only API\")\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 15aa600ed581..75d57c2a2ffd 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1281,7 +1281,7 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &controls)\n {\n \tif (state_ == State::Stopped)\n-\t\thandleState();\n+\t\treturn;\n \n \tFrameBuffer *buffer = isp_[Isp::Stats].getBuffers().at(bufferId);\n \n@@ -1314,7 +1314,7 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &\n void RPiCameraData::runIsp(uint32_t bufferId)\n {\n \tif (state_ == State::Stopped)\n-\t\thandleState();\n+\t\treturn;\n \n \tFrameBuffer *buffer = unicam_[Unicam::Image].getBuffers().at(bufferId);\n \n@@ -1329,7 +1329,7 @@ void RPiCameraData::runIsp(uint32_t bufferId)\n void RPiCameraData::embeddedComplete(uint32_t bufferId)\n {\n \tif (state_ == State::Stopped)\n-\t\thandleState();\n+\t\treturn;\n \n \tFrameBuffer *buffer = unicam_[Unicam::Embedded].getBuffers().at(bufferId);\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Embedded]);\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }