Patch Detail
Show a patch.
GET /api/1.1/patches/11295/?format=api
{ "id": 11295, "url": "https://patchwork.libcamera.org/api/1.1/patches/11295/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11295/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210215101200.149457-2-paul.elder@ideasonboard.com>", "date": "2021-02-15T10:11:57", "name": "[libcamera-devel,v3,1/4] libcamera: properties: Add Unknown value to camera Location", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "7818fe3aa93854b43bc279735cc2b5474761e185", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11295/mbox/", "series": [ { "id": 1693, "url": "https://patchwork.libcamera.org/api/1.1/series/1693/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1693", "date": "2021-02-15T10:11:56", "name": "Add Unknown camera location", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1693/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11295/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11295/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28B82BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Feb 2021 10:12:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EACD2637C4;\n\tMon, 15 Feb 2021 11:12:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03AF16375F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Feb 2021 11:12:15 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 987FB743;\n\tMon, 15 Feb 2021 11:12:12 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QDVwwx+w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613383934;\n\tbh=31tnoUZ4J0/jdeQvMwQ2RoWnfPl5feEqhFD72m2mSvc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QDVwwx+wpwTS4aWTRSHbkhITfOxAa4Q7JDGPfUAM7jjFVYtS+MumqIWL9qD82Uiq/\n\tnxINW1BIIffGw99VN4S7z7UL7FZNuvCGam+DEqC5jWwZMtjaTkv3vXw5BLQ70FTpq7\n\tnVAqgNaQXqldi3SDMuCH0NrLAiqwKi43D3hFLW1Y=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 15 Feb 2021 19:11:57 +0900", "Message-Id": "<20210215101200.149457-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210215101200.149457-1-paul.elder@ideasonboard.com>", "References": "<20210215101200.149457-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 1/4] libcamera: properties: Add Unknown\n\tvalue to camera Location", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If a camera's location is unknown, it should be set so, and not\ndefaulted to another location. Add such a value to the Location property\nenum.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nNo change in v3\n\nChanges in v2:\n- Unknown is now 0, the rest are incremented by 1\n---\n src/libcamera/property_ids.yaml | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 104e9aaf..fd17bf0c 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -10,18 +10,22 @@ controls:\n description: |\n Camera mounting location\n enum:\n- - name: CameraLocationFront\n+ - name: CameraLocationUnknown\n value: 0\n+ description: |\n+ The camera location is unknown\n+ - name: CameraLocationFront\n+ value: 1\n description: |\n The camera is mounted on the front side of the device, facing the\n user\n - name: CameraLocationBack\n- value: 1\n+ value: 2\n description: |\n The camera is mounted on the back side of the device, facing away\n from the user\n - name: CameraLocationExternal\n- value: 2\n+ value: 3\n description: |\n The camera is attached to the device in a way that allows it to\n be moved freely\n", "prefixes": [ "libcamera-devel", "v3", "1/4" ] }