Patch Detail
Show a patch.
GET /api/1.1/patches/11225/?format=api
{ "id": 11225, "url": "https://patchwork.libcamera.org/api/1.1/patches/11225/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11225/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210211071846.35161-6-paul.elder@ideasonboard.com>", "date": "2021-02-11T07:18:39", "name": "[libcamera-devel,v7,05/12] libcamera: IPAProxy: Remove stop() override", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "9048e78e3804a130af1623ccc0fbbfa8c2b84715", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11225/mbox/", "series": [ { "id": 1676, "url": "https://patchwork.libcamera.org/api/1.1/series/1676/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1676", "date": "2021-02-11T07:18:34", "name": "IPA isolation: Part 2: Conversion and plumbing", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1676/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11225/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11225/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 316A1BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Feb 2021 07:19:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDAAD61683;\n\tThu, 11 Feb 2021 08:19:09 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E049961666\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Feb 2021 08:19:08 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 83B1F41;\n\tThu, 11 Feb 2021 08:19:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QdRR/rEV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613027948;\n\tbh=dZegylZHaN5I47s6GAtvUhETRd/cm8rc73kxj6X0IRk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QdRR/rEV3pAr6E/lv1ssoE+nsTmnekCR8V3ixi4vxHZragy2MDCwXMlQt8cjl2Dqr\n\tV0VftmTIGExsr6Bm6Ciw6ELAdp9rqhuKKSIea2zN6CdC5e7tDconzGe9qnMuAZVg14\n\tHFAz1QZ9V/c0hjIV1bf0V+FvfXPVlblWP4EgyX8I=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Feb 2021 16:18:39 +0900", "Message-Id": "<20210211071846.35161-6-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210211071846.35161-1-paul.elder@ideasonboard.com>", "References": "<20210211071846.35161-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 05/12] libcamera: IPAProxy: Remove\n\tstop() override", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since stop() is part of the IPA interface, and the IPA interface is now\ngenerated based on the data definition file per pipeline, this no longer\nneeds to be overrided by the base IPAProxy. Remove it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v7\n\nNo change in v6\n\nNo change in v5\n\nNo change in v4\n\nNo change in v3\n\nChanges in v2:\n- remove documentation\n---\n include/libcamera/internal/ipa_proxy.h | 2 --\n src/libcamera/ipa_proxy.cpp | 10 ----------\n 2 files changed, 12 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex 49399f4e..59a5b841 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -27,8 +27,6 @@ public:\n \n \tstd::string configurationFile(const std::string &file) const;\n \n-\tvoid stop() override = 0;\n-\n protected:\n \tstd::string resolvePath(const std::string &file) const;\n \ndiff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex ff4d7fd1..23be24ad 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -145,16 +145,6 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n \treturn std::string();\n }\n \n-/**\n- * \\fn IPAProxy::stop()\n- * \\brief Stop the IPA proxy\n- *\n- * This function stops the IPA and releases all the resources acquired by the\n- * proxy in start(). Calling stop() when the IPA proxy hasn't been started or\n- * has already been stopped is valid, the proxy shall treat this as a no-op and\n- * shall not forward the call to the IPA.\n- */\n-\n /**\n * \\brief Find a valid full path for a proxy worker for a given executable name\n * \\param[in] file File name of proxy worker executable\n", "prefixes": [ "libcamera-devel", "v7", "05/12" ] }