Patch Detail
Show a patch.
GET /api/1.1/patches/11204/?format=api
{ "id": 11204, "url": "https://patchwork.libcamera.org/api/1.1/patches/11204/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11204/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-02-09T15:03:35", "name": "[libcamera-devel] ipa: ipu3: Don't call SetControls for each frame", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "53a60c0bd6c38c6c455e083b7fbd0a042c33da85", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/1.1/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11204/mbox/", "series": [ { "id": 1672, "url": "https://patchwork.libcamera.org/api/1.1/series/1672/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1672", "date": "2021-02-09T15:03:35", "name": "[libcamera-devel] ipa: ipu3: Don't call SetControls for each frame", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1672/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11204/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11204/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 750A0BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 9 Feb 2021 15:03:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 053F761629;\n\tTue, 9 Feb 2021 16:03:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B04A560D16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Feb 2021 16:03:37 +0100 (CET)", "from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:4d26:9423:a9d1:8c4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31EAD9AA;\n\tTue, 9 Feb 2021 16:03:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BfAwiacI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612883017;\n\tbh=05mC+v5P8QDC1RzePSYjHtts1afgFlBwyft0+JETr8g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=BfAwiacIafIHAUl4KdJXT1x6GFpa7CUP9nSBn11zg9TA0U93hanGSpHp/PA5dPGlS\n\tIWXwrUuchQSkqc1QAS02bytMTxr5XWvKRw6oH6FvzIQvJPc47gMn9ii+gsjqr+iEzK\n\taab0dgkLNQjbVoGz9PG8ensHNMdT7xNMFHFpFoZE=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 9 Feb 2021 16:03:35 +0100", "Message-Id": "<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\nframe but there is no need to force it for all frames.\nIt will be called later by the 3A algorithms.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b11b03ef..ae7e8c0b 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n \n \tqueueFrameAction.emit(frame, op);\n-\n-\t/* \\todo Calculate new values for exposure_ and gain_. */\n-\tsetControls(frame);\n }\n \n void IPAIPU3::parseStatistics(unsigned int frame,\n", "prefixes": [ "libcamera-devel" ] }