Patch Detail
Show a patch.
GET /api/1.1/patches/11201/?format=api
{ "id": 11201, "url": "https://patchwork.libcamera.org/api/1.1/patches/11201/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11201/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210208234733.2637061-2-niklas.soderlund@ragnatech.se>", "date": "2021-02-08T23:47:32", "name": "[libcamera-devel,RFC,1/2] libcamera: IPCPipeUnixSocket: Check that insertion succeeds", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "253e3975509b0d48c54cbeb92f1123de745b1348", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11201/mbox/", "series": [ { "id": 1670, "url": "https://patchwork.libcamera.org/api/1.1/series/1670/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1670", "date": "2021-02-08T23:47:31", "name": "ipu3: Translate IPA protocol to new mojo interface", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1670/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11201/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11201/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD1DBBD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Feb 2021 23:47:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D535C6160C;\n\tTue, 9 Feb 2021 00:47:55 +0100 (CET)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31AF960D3A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Feb 2021 00:47:54 +0100 (CET)", "from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 0f651e7c-6a68-11eb-a076-005056917f90;\n\tTue, 09 Feb 2021 00:47:53 +0100 (CET)" ], "X-Halon-ID": "0f651e7c-6a68-11eb-a076-005056917f90", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "Paul Elder <paul.elder@ideasonboard.com>", "Date": "Tue, 9 Feb 2021 00:47:32 +0100", "Message-Id": "<20210208234733.2637061-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210208234733.2637061-1-niklas.soderlund@ragnatech.se>", "References": "<20210208234733.2637061-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC 1/2] libcamera: IPCPipeUnixSocket: Check\n\tthat insertion succeeds", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make sure the insertion succeeds. This was found by compile tests\nwith gcc7 which points out 'success' is not used.\n\n ../../src/libcamera/ipc_pipe_unixsocket.cpp:119:27: error: unused variable ‘success’ [-Werror=unused-variable]\n const auto [iter, success] = callData_.insert({ cookie, { response, false } });\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/ipc_pipe_unixsocket.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/ipc_pipe_unixsocket.cpp b/src/libcamera/ipc_pipe_unixsocket.cpp\nindex 2bdce29e24d9acd1..cdb7eae0653384eb 100644\n--- a/src/libcamera/ipc_pipe_unixsocket.cpp\n+++ b/src/libcamera/ipc_pipe_unixsocket.cpp\n@@ -118,6 +118,11 @@ int IPCPipeUnixSocket::call(const IPCUnixSocket::Payload &message,\n \n \tconst auto [iter, success] = callData_.insert({ cookie, { response, false } });\n \n+\tif (!success) {\n+\t\tLOG(IPCPipe, Error) << \"Failed to insert call data\";\n+\t\treturn -EINVAL;\n+\t}\n+\n \tret = socket_->send(message);\n \tif (ret) {\n \t\tcallData_.erase(iter);\n", "prefixes": [ "libcamera-devel", "RFC", "1/2" ] }