Patch Detail
Show a patch.
GET /api/1.1/patches/1120/?format=api
{ "id": 1120, "url": "https://patchwork.libcamera.org/api/1.1/patches/1120/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1120/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190427121608.13331-1-laurent.pinchart@ideasonboard.com>", "date": "2019-04-27T12:16:08", "name": "[libcamera-devel] test: signal: Exercise the signal delivery code paths for Object", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b47e905a93349ec8e371048e6b1e36dc49b7cf33", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1120/mbox/", "series": [ { "id": 277, "url": "https://patchwork.libcamera.org/api/1.1/series/277/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=277", "date": "2019-04-27T12:16:08", "name": "[libcamera-devel] test: signal: Exercise the signal delivery code paths for Object", "version": 1, "mbox": "https://patchwork.libcamera.org/series/277/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1120/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1120/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CBC060004\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Apr 2019 14:16:28 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A120C5F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Apr 2019 14:16:27 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556367387;\n\tbh=qMFALYn831tpfIGcnWFMrAg4wxfyvikkAOTC56H9eTI=;\n\th=From:To:Subject:Date:From;\n\tb=g6GOI8NWIBUGsL2Aunr+54MZ5y/xbJnzCpif/66FG2m1WqJWq2s2H3dHCae8OdBI+\n\tTuhDsjN0WzhgpmxDaqSDMqHtNuzSHcJSuSBLeLsOzIv7svstGs4xs6b5fV7O+If/iN\n\tjzq8yNZWpKxOtD1rJhwDltEcuM01WNgI/jmgOpX8=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 27 Apr 2019 15:16:08 +0300", "Message-Id": "<20190427121608.13331-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] test: signal: Exercise the signal\n\tdelivery code paths for Object", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 27 Apr 2019 12:16:28 -0000" }, "content": "Member slots for objects deriving from the Object class receive special\nhandling. Add one test to make sure we exercise the related code paths.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/signal.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/test/signal.cpp b/test/signal.cpp\nindex 19a52c603a4a..bc579cca37e4 100644\n--- a/test/signal.cpp\n+++ b/test/signal.cpp\n@@ -176,6 +176,18 @@ protected:\n \t\tdelete signal;\n \t\tdelete slotObject;\n \n+\t\t/* Exercise the the Object slot code paths. */\n+\t\tslotObject = new SlotObject();\n+\t\tsignalVoid_.connect(slotObject, &SlotObject::slot);\n+\t\tvalueStatic_ = 0;\n+\t\tsignalVoid_.emit();\n+\t\tif (valueStatic_ == 0) {\n+\t\t\tcout << \"Signal delivery for Object test failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tdelete slotObject;\n+\n \t\treturn TestPass;\n \t}\n \n", "prefixes": [ "libcamera-devel" ] }