Patch Detail
Show a patch.
GET /api/1.1/patches/11171/?format=api
{ "id": 11171, "url": "https://patchwork.libcamera.org/api/1.1/patches/11171/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11171/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210204232613.494121-10-niklas.soderlund@ragnatech.se>", "date": "2021-02-04T23:26:11", "name": "[libcamera-devel,v4,09/11] libcamera: ipu3: Map buffers in IPA", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "997fd6388ae5f08890fab8f902bfcc96a403b8fc", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11171/mbox/", "series": [ { "id": 1656, "url": "https://patchwork.libcamera.org/api/1.1/series/1656/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1656", "date": "2021-02-04T23:26:02", "name": "libcamera: ipu3: Attach to an skeleton IPA", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1656/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11171/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11171/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6896FBD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Feb 2021 23:27:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 444AF614B4;\n\tFri, 5 Feb 2021 00:27:17 +0100 (CET)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FE44614A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Feb 2021 00:27:15 +0100 (CET)", "from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 82a1eb24-6740-11eb-b73f-0050569116f7;\n\tFri, 05 Feb 2021 00:27:14 +0100 (CET)" ], "X-Halon-ID": "82a1eb24-6740-11eb-b73f-0050569116f7", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Feb 2021 00:26:11 +0100", "Message-Id": "<20210204232613.494121-10-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210204232613.494121-1-niklas.soderlund@ragnatech.se>", "References": "<20210204232613.494121-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 09/11] libcamera: ipu3: Map buffers in\n\tIPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Map and unmap the parameters and statistic buffers in the IPA when the\npipeline handler allocates and frees the buffers.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n* Changes since v2\n- Reorder lines around argument to ipaBuffers_.push_back().\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 30 ++++++++++++++++++++++++++++\n 1 file changed, 30 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 13af86001b3ec403..092db6389833a481 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -141,6 +141,8 @@ private:\n \tImgUDevice imgu1_;\n \tMediaDevice *cio2MediaDev_;\n \tMediaDevice *imguMediaDev_;\n+\n+\tstd::vector<IPABuffer> ipaBuffers_;\n };\n \n IPU3CameraConfiguration::IPU3CameraConfiguration(IPU3CameraData *data)\n@@ -586,6 +588,27 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\t/* Map buffers to the IPA. */\n+\tunsigned int ipaBufferId = 1;\n+\n+\tfor (const std::unique_ptr<FrameBuffer> &buffer : imgu->paramBuffers_) {\n+\t\tbuffer->setCookie(ipaBufferId++);\n+\t\tipaBuffers_.push_back({\n+\t\t\t.id = buffer->cookie(),\n+\t\t\t.planes = buffer->planes()\n+\t\t});\n+\t}\n+\n+\tfor (const std::unique_ptr<FrameBuffer> &buffer : imgu->statBuffers_) {\n+\t\tbuffer->setCookie(ipaBufferId++);\n+\t\tipaBuffers_.push_back({\n+\t\t\t.id = buffer->cookie(),\n+\t\t\t.planes = buffer->planes()\n+\t\t});\n+\t}\n+\n+\tdata->ipa_->mapBuffers(ipaBuffers_);\n+\n \treturn 0;\n }\n \n@@ -593,6 +616,13 @@ int PipelineHandlerIPU3::freeBuffers(Camera *camera)\n {\n \tIPU3CameraData *data = cameraData(camera);\n \n+\tstd::vector<unsigned int> ids;\n+\tfor (IPABuffer &ipabuf : ipaBuffers_)\n+\t\tids.push_back(ipabuf.id);\n+\n+\tdata->ipa_->unmapBuffers(ids);\n+\tipaBuffers_.clear();\n+\n \tdata->imgu_->freeBuffers();\n \n \treturn 0;\n", "prefixes": [ "libcamera-devel", "v4", "09/11" ] }