Patch Detail
Show a patch.
GET /api/1.1/patches/11146/?format=api
{ "id": 11146, "url": "https://patchwork.libcamera.org/api/1.1/patches/11146/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11146/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210204143736.1762344-1-kieran.bingham@ideasonboard.com>", "date": "2021-02-04T14:37:36", "name": "[libcamera-devel] android: jpeg: Utilise compiler specific nodiscard", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "7acbe73b89345ca1005730b71114a52d9903ad2e", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11146/mbox/", "series": [ { "id": 1652, "url": "https://patchwork.libcamera.org/api/1.1/series/1652/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1652", "date": "2021-02-04T14:37:36", "name": "[libcamera-devel] android: jpeg: Utilise compiler specific nodiscard", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1652/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11146/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11146/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A680BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Feb 2021 14:37:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17D436141E;\n\tThu, 4 Feb 2021 15:37:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10D8A60305\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Feb 2021 15:37:43 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 914E9440;\n\tThu, 4 Feb 2021 15:37:42 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tjLnTGDs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612449462;\n\tbh=/WftimkzWqPxhFx8DC8yCSrAmZ1OqnNFHtmuCUlegzE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tjLnTGDszss4bYPiP0G5CjDE5OSkXL8bAI3UqD+Q3+STVocu+piQwgSgAt/c3WFCk\n\tfXSdnShXisSZXSqOpH069I7azVdh36vpMTb4OtUPnNWPN5UuPQJGjbtVidPgNhVXGS\n\twUwG9/+nbh54xDBDvvGRlrHQV/Wx8BUCDoGF59Qs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 4 Feb 2021 14:37:36 +0000", "Message-Id": "<20210204143736.1762344-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210204035951.23751-1-laurent.pinchart@ideasonboard.com>", "References": "<20210204035951.23751-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] android: jpeg: Utilise compiler specific\n\tnodiscard", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Utilise the new compiler specific __nodiscard to maintain coding style.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nOnly applicable along with Laurent's [[nodiscard]] series.\n\n\n src/android/jpeg/exif.cpp | 2 +-\n src/android/jpeg/exif.h | 3 ++-\n 2 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex fdd46070ba7c..ed995ca13167 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -515,7 +515,7 @@ std::u16string Exif::utf8ToUtf16(const std::string &str)\n \treturn ret;\n }\n \n-[[nodiscard]] int Exif::generate()\n+__nodiscard int Exif::generate()\n {\n \tif (exifData_) {\n \t\tfree(exifData_);\ndiff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\nindex b0d614027ede..67dbd20524d8 100644\n--- a/src/android/jpeg/exif.h\n+++ b/src/android/jpeg/exif.h\n@@ -13,6 +13,7 @@\n \n #include <libexif/exif-data.h>\n \n+#include <libcamera/compiler.h>\n #include <libcamera/geometry.h>\n #include <libcamera/span.h>\n \n@@ -75,7 +76,7 @@ public:\n \tvoid setWhiteBalance(WhiteBalance wb);\n \n \tlibcamera::Span<const uint8_t> data() const { return { exifData_, size_ }; }\n-\t[[nodiscard]] int generate();\n+\t__nodiscard int generate();\n \n private:\n \tExifEntry *createEntry(ExifIfd ifd, ExifTag tag);\n", "prefixes": [ "libcamera-devel" ] }