Patch Detail
Show a patch.
GET /api/1.1/patches/11137/?format=api
{ "id": 11137, "url": "https://patchwork.libcamera.org/api/1.1/patches/11137/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11137/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210204093457.6879-8-david.plowman@raspberrypi.com>", "date": "2021-02-04T09:34:57", "name": "[libcamera-devel,7/7] ipa: raspberrypi: Remove atomic variable from Algorithm class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "836533adb38f8d80019f9b1c07ceaef3371bd881", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11137/mbox/", "series": [ { "id": 1649, "url": "https://patchwork.libcamera.org/api/1.1/series/1649/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1649", "date": "2021-02-04T09:34:50", "name": "Raspberry Pi IPA maintenance", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1649/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11137/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11137/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57CA6BD163\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Feb 2021 09:35:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2222D6142E;\n\tThu, 4 Feb 2021 10:35:10 +0100 (CET)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3189A6141D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Feb 2021 10:35:07 +0100 (CET)", "by mail-wm1-x32f.google.com with SMTP id j11so2492894wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Feb 2021 01:35:07 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tg16sm5280580wmi.30.2021.02.04.01.35.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:35:06 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mtaYI8Lh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kLdoAI0DrQKDp9rJnYmfItefNZa1u0XSjvvtceMdilg=;\n\tb=mtaYI8Lhw2J5yWBvlyOv7WNb1YMyhKfkcMa73xshr+RgMez1YkEPB47WzXE4yihst9\n\tb3N3JadL5bpl0AoewMj/1ay5J8aijQMgvm9fDz0NjQC1Il5M/PuxM1q2JVTPB3QSjMCO\n\tajLyglZ8WO2uMEMp4moT06mE3QvUgwYETOpajnvwjtlFsaiu798THxcY5jXtKZZn0zTy\n\tMR8EEQwOJEiilaa5ZkrcCdPBAoe7m4b1GxnR82DRk1SjCU4P49k8xNJaPTVecC3SBTYb\n\tgtseqZWcCzzwNldOaBKLQglV1Ps3gqX9ANTrD9biNd10qdYU+m+yFARqFMgf9a9dBIMS\n\t/VsA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=kLdoAI0DrQKDp9rJnYmfItefNZa1u0XSjvvtceMdilg=;\n\tb=e56CtfVZMr7rO+rvPdbOwCnhGCu9rJMkI+qRRK57JTK6eBIsKsTJwrzod93AVLUknp\n\tR7l8T4w/DorH3rP6fTCC28n1uBk919ejeXE/V8+GPm9Uji74ZLD4LFyxFgwwh+ijDlmO\n\tmWcfWPDGTbNkRWobQlaWErMcF5TjJa6sd8uyH8Ei2pwIijxRQz0H8c5ZndUoFJqXjC1S\n\tRucktr7BQxKTR1yVmSZd8ahN70XdYKGykNA7jgXePqmJhMNeldJUR2SQlJ/ScZUV75m3\n\tiWZgT3zxDlYii0HTTIjSU6d3yqtlCWC0YXKEhN0TKUEmWcbRdAsGrAGSu/PZakJwqOj4\n\t+VlQ==", "X-Gm-Message-State": "AOAM5327HlP7Eiw2eubKUuPBQejXq//5BKAIFlxYQ/7E3Y//D8AtiQI3\n\tTeopg5SnOP09sRuOboht4UwYULJUo8rGT2x3", "X-Google-Smtp-Source": "ABdhPJxS++qU2lTHWIzBEYgK01KXgUc/QdN79xH0HQTjYuGaMq/yEFdOPuuBobzqjbY/Go9Wv7LiJA==", "X-Received": "by 2002:a1c:99d1:: with SMTP id\n\tb200mr6610206wme.37.1612431306701; \n\tThu, 04 Feb 2021 01:35:06 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Feb 2021 09:34:57 +0000", "Message-Id": "<20210204093457.6879-8-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210204093457.6879-1-david.plowman@raspberrypi.com>", "References": "<20210204093457.6879-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 7/7] ipa: raspberrypi: Remove atomic\n\tvariable from Algorithm class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Pause() and Resume() are only called synchronously so paused_ does not\nneed to be atomic.\n\nWith this commit, libatomic can finally be removed as a build\ndependency.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/algorithm.hpp | 3 +--\n src/ipa/raspberrypi/meson.build | 1 -\n 2 files changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp\nindex e9b040c7..5123c87b 100644\n--- a/src/ipa/raspberrypi/controller/algorithm.hpp\n+++ b/src/ipa/raspberrypi/controller/algorithm.hpp\n@@ -12,7 +12,6 @@\n #include <string>\n #include <memory>\n #include <map>\n-#include <atomic>\n \n #include \"controller.hpp\"\n \n@@ -46,7 +45,7 @@ public:\n \n private:\n \tController *controller_;\n-\tstd::atomic<bool> paused_;\n+\tbool paused_;\n };\n \n // This code is for automatic registration of Front End algorithms with the\ndiff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\nindex 9445cd09..4cdd0434 100644\n--- a/src/ipa/raspberrypi/meson.build\n+++ b/src/ipa/raspberrypi/meson.build\n@@ -5,7 +5,6 @@ ipa_name = 'ipa_rpi'\n rpi_ipa_deps = [\n libcamera_dep,\n dependency('boost'),\n- libatomic,\n ]\n \n rpi_ipa_includes = [\n", "prefixes": [ "libcamera-devel", "7/7" ] }