Patch Detail
Show a patch.
GET /api/1.1/patches/11133/?format=api
{ "id": 11133, "url": "https://patchwork.libcamera.org/api/1.1/patches/11133/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11133/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210204093457.6879-4-david.plowman@raspberrypi.com>", "date": "2021-02-04T09:34:53", "name": "[libcamera-devel,3/7] ipa: raspberrypi: ccm: Remove unnecessary atomic variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5948746bcf28632255d87b65708d29a57b922723", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11133/mbox/", "series": [ { "id": 1649, "url": "https://patchwork.libcamera.org/api/1.1/series/1649/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1649", "date": "2021-02-04T09:34:50", "name": "Raspberry Pi IPA maintenance", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1649/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11133/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11133/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E343BBD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Feb 2021 09:35:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 742F761422;\n\tThu, 4 Feb 2021 10:35:07 +0100 (CET)", "from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1017761404\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Feb 2021 10:35:04 +0100 (CET)", "by mail-wr1-x42f.google.com with SMTP id u14so2685975wri.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Feb 2021 01:35:04 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tg16sm5280580wmi.30.2021.02.04.01.35.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:35:03 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"lrIbvjC4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=gBTFzAW/1hF57reoTu/2os27+DX/gEecEzMfr1mtMnQ=;\n\tb=lrIbvjC4KuxkQ2hQqkq0+Q7YKz9zIPKKc2Jp9uF66udVFQ9itrfcHvfSf2a66mul8Q\n\tQciRi6CCEwBlC89BbOZb96oc5o03rbx3Q178xErBDB/flf2GVQTFlk9cTxuEdjSVQhpv\n\tp3k4wN887kMlg8naoun6VoCtqn0DxnfVw9JbSsZc4OmZ6V7yDI/6DilfEg8fIJ3Zdbzl\n\t35xfsXEDxrbGXdFZCo679xuAUzoApnjvG9GSD2E/QXrjyx5P0jrCc7ZIS4GbAPoqbayS\n\t7muriRJKVLfzY+wBv+AVgXp7mW6RQ7kvGQVMM8pGGLe4fypyWzXizkjxKZLE7vJIP42c\n\tQzcQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=gBTFzAW/1hF57reoTu/2os27+DX/gEecEzMfr1mtMnQ=;\n\tb=Y1ShG7yWiZ8YJIQ1+adOEHvTyplo56gCPEL4S4aCMi39Ez7Dz0Bx1fsRssB3YFXFiB\n\tkW4DO1KxwuBRTOO3nCnrMtQyEsZhb//OjfHNMoOrxDdubK/ulkNPGYY8laSMcE4hff6V\n\tXM3hMfRZ4RaHDDrSKC+jLlduRiCOg9YnNVC+fvBJV8XPWbvavs4+1UfG+CtQzba42cmg\n\t+JYb6Z+mtudcIdKZm/s5MXhtwhBRgfL4EVp2Hc1vqtzM+bHZOuxdQU4o2ZrwDgChw1sR\n\taaIRYlfavRFBM5Gw/WvrEOq9nhGhjyUQLXgElDkW5FXfSaHNIfBO+Y/fh5Vo6PzMNRUW\n\tx86Q==", "X-Gm-Message-State": "AOAM530g5R4KXcq8t+vL8p4m9kG9maPMT7ackEM9h6zAUdmOjYbQ2vXY\n\t4WKyoWXhVdh+nTI8zjQNW4oZgYhZTQ9R7zzj", "X-Google-Smtp-Source": "ABdhPJxhvTDmLL+vB749bIbgn1m9T88kZf7Ju/ICoHOP+VC8Y4viZu0z+Xd2E8UeyUrvzdCTCFW+6A==", "X-Received": "by 2002:a5d:4dd0:: with SMTP id\n\tf16mr8235254wru.304.1612431303647; \n\tThu, 04 Feb 2021 01:35:03 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Feb 2021 09:34:53 +0000", "Message-Id": "<20210204093457.6879-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210204093457.6879-1-david.plowman@raspberrypi.com>", "References": "<20210204093457.6879-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/7] ipa: raspberrypi: ccm: Remove\n\tunnecessary atomic variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "SetSaturation() gets called synchronously so there is no need for\nsaturation_ to be atomic.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/ccm.hpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/ccm.hpp b/src/ipa/raspberrypi/controller/rpi/ccm.hpp\nindex fcf077e7..330ed51f 100644\n--- a/src/ipa/raspberrypi/controller/rpi/ccm.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/ccm.hpp\n@@ -7,7 +7,6 @@\n #pragma once\n \n #include <vector>\n-#include <atomic>\n \n #include \"../ccm_algorithm.hpp\"\n #include \"../pwl.hpp\"\n@@ -70,7 +69,7 @@ public:\n \n private:\n \tCcmConfig config_;\n-\tstd::atomic<double> saturation_;\n+\tdouble saturation_;\n };\n \n } // namespace RPiController\n", "prefixes": [ "libcamera-devel", "3/7" ] }