Patch Detail
Show a patch.
GET /api/1.1/patches/1111/?format=api
{ "id": 1111, "url": "https://patchwork.libcamera.org/api/1.1/patches/1111/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1111/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190426150155.18652-6-laurent.pinchart@ideasonboard.com>", "date": "2019-04-26T15:01:52", "name": "[libcamera-devel,5/8] libcamera: v4l2_device: Buffer is not a struct", "commit_ref": "4088ae7a20034270b632a5a3b163490a9654ae1d", "pull_url": null, "state": "accepted", "archived": false, "hash": "098371a45fbd21b1b31b1014b8de13efa86c9cb7", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1111/mbox/", "series": [ { "id": 271, "url": "https://patchwork.libcamera.org/api/1.1/series/271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=271", "date": "2019-04-26T15:01:47", "name": "Fix clang compilation warnings and errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1111/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1111/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F156160E9D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:10 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FA9A5F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:10 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290930;\n\tbh=m3PfYlp0guQw8AWHBXLienX/vV8XL3Q2hiab8KCQcSE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=eIqFJIG/I37Wm2alMhjYGfEth85rpokHg62lieBszSWFESTEY32+Zs7FEdY/NiPGH\n\tx1C4IiWp5aGhn2gKDm0hd93vTJSnLXtS6UMPVx2P6LIfD9RjSVezIpAHwjv5+3NU5H\n\tndY+9Etchrl72ZyQqIo2/JTThd0WJlY68ha4OLOM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Apr 2019 18:01:52 +0300", "Message-Id": "<20190426150155.18652-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "References": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 5/8] libcamera: v4l2_device: Buffer is not\n\ta struct", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 26 Apr 2019 15:02:11 -0000" }, "content": "Buffer is a class, not a struct. Fix a variable declaration accordingly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/v4l2_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 8d8c7887bf71..cfdce4813da4 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -622,7 +622,7 @@ int V4L2Device::exportBuffers(BufferPool *pool)\n \tfor (i = 0; i < pool->count(); ++i) {\n \t\tstruct v4l2_plane planes[VIDEO_MAX_PLANES] = {};\n \t\tstruct v4l2_buffer buf = {};\n-\t\tstruct Buffer &buffer = pool->buffers()[i];\n+\t\tBuffer &buffer = pool->buffers()[i];\n \n \t\tbuf.index = i;\n \t\tbuf.type = bufferType_;\n", "prefixes": [ "libcamera-devel", "5/8" ] }