Patch Detail
Show a patch.
GET /api/1.1/patches/1107/?format=api
{ "id": 1107, "url": "https://patchwork.libcamera.org/api/1.1/patches/1107/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1107/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190426150155.18652-2-laurent.pinchart@ideasonboard.com>", "date": "2019-04-26T15:01:48", "name": "[libcamera-devel,1/8] libcamera: Correct struct forward declarations", "commit_ref": "152147c539d8e0e920547167c462c54d744601f7", "pull_url": null, "state": "accepted", "archived": false, "hash": "3dee6e80d52bc67d1c0b40847e2216054fedaaa8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1107/mbox/", "series": [ { "id": 271, "url": "https://patchwork.libcamera.org/api/1.1/series/271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=271", "date": "2019-04-26T15:01:47", "name": "Fix clang compilation warnings and errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1107/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1107/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE12D60E9A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:09 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53758337\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:09 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290929;\n\tbh=vOFvJ00xOx/+CxLYLuN5oZBPNBjxDDzy+HvXyxArXYE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Ee+SZmI+k24I/qMzfETIH0elRa9uDEYIoPdujaHXsowSKxdpFHS0s/8dHal+e4DEv\n\tTHi4XU/zTjeig/XFKG36fLdQo7UaG5f8bP1TYHotCrpONmr+9v7s/Z8p6PBaUlxleS\n\tixp3TH6QGDIgIPr+1d0RTk8zZfaT4Auj3VzSNUUc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 26 Apr 2019 18:01:48 +0300", "Message-Id": "<20190426150155.18652-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "References": "<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/8] libcamera: Correct struct forward\n\tdeclarations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 26 Apr 2019 15:02:10 -0000" }, "content": "Several structures are forward-declarated as classes. Fix this by using\nthe struct keyword where appropriate, or removing the forward\ndeclaration when not needed.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/camera.h | 3 ++-\n src/libcamera/include/camera_sensor.h | 3 ++-\n src/libcamera/include/pipeline_handler.h | 1 -\n 3 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex b2dafda342fe..777b7e4d48b8 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -21,9 +21,10 @@ class Buffer;\n class PipelineHandler;\n class Request;\n class Stream;\n-class StreamConfiguration;\n class StreamUsage;\n \n+struct StreamConfiguration;\n+\n class CameraConfiguration\n {\n public:\ndiff --git a/src/libcamera/include/camera_sensor.h b/src/libcamera/include/camera_sensor.h\nindex 7f2f906be8df..b823480241a7 100644\n--- a/src/libcamera/include/camera_sensor.h\n+++ b/src/libcamera/include/camera_sensor.h\n@@ -18,7 +18,8 @@ namespace libcamera {\n \n class MediaEntity;\n class V4L2Subdevice;\n-class V4L2SubdeviceFormat;\n+\n+struct V4L2SubdeviceFormat;\n \n class CameraSensor : protected Loggable\n {\ndiff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex c3f7d4c29205..5830e53108fa 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -26,7 +26,6 @@ class MediaDevice;\n class PipelineHandler;\n class Request;\n class Stream;\n-class StreamConfiguration;\n class StreamUsage;\n \n class CameraData\n", "prefixes": [ "libcamera-devel", "1/8" ] }