Patch Detail
Show a patch.
GET /api/1.1/patches/11063/?format=api
{ "id": 11063, "url": "https://patchwork.libcamera.org/api/1.1/patches/11063/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11063/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210129151154.1051163-4-naush@raspberrypi.com>", "date": "2021-01-29T15:11:51", "name": "[libcamera-devel,v5,3/6] uapi: raspberrypi: Update the bcm2835-isp header definition", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b4ce3c3aa49bfa21660f80552fef0643510192b9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11063/mbox/", "series": [ { "id": 1627, "url": "https://patchwork.libcamera.org/api/1.1/series/1627/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1627", "date": "2021-01-29T15:11:48", "name": "Raspberry Pi: Colour denoise", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1627/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11063/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11063/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79BF3BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Jan 2021 15:12:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D0A3683C0;\n\tFri, 29 Jan 2021 16:12:05 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21E44683BB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jan 2021 16:12:03 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id f16so7093835wmq.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jan 2021 07:12:03 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tf13sm6517461wmf.1.2021.01.29.07.12.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jan 2021 07:12:01 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SYtjOHn9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=bjrxqpQgzDBa9WkS2S3Mn4TK2H7Bqit1lomfmatnMZc=;\n\tb=SYtjOHn9o9XUAQzSp8230RQXlTowDmXY/7zMw9hFVYxQp++A6LA5zN+bVYptIEhTLJ\n\tvQGLZeabciUUBx0Cvdp97oITo4NgDH35eMV8t7GvHhsK8wW63RKJPUtxM9j+Lv+mMVeb\n\ts3b/UKXkQBsfZ9v5diwqhi8PCilaRgmvzJT782rYju1T5AznufG+7TlCipYczdC2O7BK\n\tIz8OI50xVuLvSmvEBOCdcjZ8Yp0PEkPYUl7VEP4YOdAfSO2rEgzt/btJWTiQA++22Svi\n\tJiA8NUy4i3LJYDtg+ODDgsIdr1ajs4faxqC4KAlF+4P0WISiWWuyvrzoHaZvLM3MC29X\n\t2zhw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=bjrxqpQgzDBa9WkS2S3Mn4TK2H7Bqit1lomfmatnMZc=;\n\tb=mACV97BLPg6Ou7qbTIj3glNK2nQdRcb1ecn8nhqoZ6Gw+HGVP2la7y+BFepJMhhr//\n\tg89cvV4zmXi8GLKujEVkpO1KXlzOocAdwukgZNNIgYdwJRcbwSPTlrA1qgHK7jF6bpAN\n\tU1DaLEzUWrUnxv0JifZ+fDrCb48sSWkPMIYXS4gviCFETZLLYH19e/SV/wucFP9a0mAx\n\tX3TTzFk3g5vuauuaFmWI4ptMbFTzM0SrB3qCP1rovURSDqsmm53DFo2QFgJ1wK0KwxRh\n\thd6GSN3RbmxPMfesUtNCpXni06qy2Dw+Xu0S8aohOBVTOdeGXZLi3O7gODjQm5UM7Yxm\n\tzC4Q==", "X-Gm-Message-State": "AOAM532AjQRYVPNMl9jfq/Y+97Zs9H1pvjOF3mdDvY+4sCuk/I3YJG22\n\tquxU/kXSuaTaw585K+Mg3EY9hmjcQPflISKZ", "X-Google-Smtp-Source": "ABdhPJzfzFItz3R3dr48sfv8hebCVa5FfdzEjRgUrq10RXsUSNPs35EmaPsx09A8Cut35/RLDVBo2A==", "X-Received": "by 2002:a1c:68d5:: with SMTP id\n\td204mr4273367wmc.178.1611933122552; \n\tFri, 29 Jan 2021 07:12:02 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Jan 2021 15:11:51 +0000", "Message-Id": "<20210129151154.1051163-4-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210129151154.1051163-1-naush@raspberrypi.com>", "References": "<20210129151154.1051163-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the bcm2835-isp.h file with the latest version available in the\ndownstream Raspberry Pi linux repo.\n\nThis change adds support for colour denoise processing, and the\nfollowing downstream kernel changes must be available:\nhttps://github.com/raspberrypi/linux/pull/4069\nhttps://github.com/raspberrypi/linux/pull/4083\n\nThe Raspberry Pi image must also be running the latest firmware,\nobtained by running rpi-update.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/linux/bcm2835-isp.h | 32 +++++++++++++++++++++++++++++---\n 1 file changed, 29 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/linux/bcm2835-isp.h b/include/linux/bcm2835-isp.h\nindex 45abb681517e..94c3af947883 100644\n--- a/include/linux/bcm2835-isp.h\n+++ b/include/linux/bcm2835-isp.h\n@@ -31,7 +31,8 @@\n \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0007)\n #define V4L2_CID_USER_BCM2835_ISP_DPC\t\t\\\n \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0008)\n-\n+#define V4L2_CID_USER_BCM2835_ISP_CDN \\\n+\t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0009)\n /*\n * All structs below are directly mapped onto the equivalent structs in\n * drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h\n@@ -46,7 +47,7 @@\n */\n struct bcm2835_isp_rational {\n \t__s32 num;\n-\t__s32 den;\n+\t__u32 den;\n };\n \n /**\n@@ -140,7 +141,7 @@ struct bcm2835_isp_black_level {\n \t__u16 black_level_r;\n \t__u16 black_level_g;\n \t__u16 black_level_b;\n-\t__u8 pad_[2]; /* Unused */\n+\t__u8 padding[2]; /* Unused */\n };\n \n /**\n@@ -175,6 +176,31 @@ struct bcm2835_isp_gamma {\n \t__u16 y[BCM2835_NUM_GAMMA_PTS];\n };\n \n+/**\n+ * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.\n+ *\n+ * @CDN_MODE_FAST:\t\tFast (but lower quality) colour denoise\n+ *\t\t\t\talgorithm, typically used for video recording.\n+ * @CDN_HIGH_QUALITY:\t\tHigh quality (but slower) colour denoise\n+ *\t\t\t\talgorithm, typically used for stills capture.\n+ */\n+enum bcm2835_isp_cdn_mode {\n+\tCDN_MODE_FAST = 0,\n+\tCDN_MODE_HIGH_QUALITY = 1,\n+};\n+\n+/**\n+ * struct bcm2835_isp_cdn - Colour denoise parameters set with the\n+ *\t\t\t V4L2_CID_USER_BCM2835_ISP_CDN ctrl.\n+ *\n+ * @enabled:\tEnable colour denoise.\n+ * @cdn_mode:\tColour denoise operating mode (see enum &bcm2835_isp_cdn_mode)\n+ */\n+struct bcm2835_isp_cdn {\n+\t__u32 enabled;\n+\t__u32 mode;\n+};\n+\n /**\n * struct bcm2835_isp_denoise - Denoise parameters set with the\n *\t\t\t\tV4L2_CID_USER_BCM2835_ISP_DENOISE ctrl.\n", "prefixes": [ "libcamera-devel", "v5", "3/6" ] }