Patch Detail
Show a patch.
GET /api/1.1/patches/11017/?format=api
{ "id": 11017, "url": "https://patchwork.libcamera.org/api/1.1/patches/11017/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11017/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210126173008.446321-2-jacopo@jmondi.org>", "date": "2021-01-26T17:30:03", "name": "[libcamera-devel,v2,1/6] libcamera: camera_sensor: Make VBLANK mandatory", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "de015c3f7f6774f9259f31b8bcbbf5c6774d377f", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11017/mbox/", "series": [ { "id": 1612, "url": "https://patchwork.libcamera.org/api/1.1/series/1612/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1612", "date": "2021-01-26T17:30:02", "name": "android: Report frame durations", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1612/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11017/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11017/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C1FBBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Jan 2021 17:29:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C634B6832A;\n\tTue, 26 Jan 2021 18:29:55 +0100 (CET)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D90868318\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jan 2021 18:29:53 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 59E95E0002\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jan 2021 17:29:53 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Jan 2021 18:30:03 +0100", "Message-Id": "<20210126173008.446321-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20210126173008.446321-1-jacopo@jmondi.org>", "References": "<20210126173008.446321-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 1/6] libcamera: camera_sensor: Make\n\tVBLANK mandatory", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the V4L2_CID_VBLANK control to the list of mandatory controls\nthe sensor driver has to report and document the new requirement.\n\nThe vertical blanking control is used to calculate the frame duration.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n Documentation/sensor_driver_requirements.rst | 6 ++++--\n src/libcamera/camera_sensor.cpp | 1 +\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\nindex 6dcd4e68d64d..590797f054ce 100644\n--- a/Documentation/sensor_driver_requirements.rst\n+++ b/Documentation/sensor_driver_requirements.rst\n@@ -27,18 +27,20 @@ The sensor driver shall support the following V4L2 controls:\n * `V4L2_CID_EXPOSURE`_\n * `V4L2_CID_HBLANK`_\n * `V4L2_CID_PIXEL_RATE`_\n+* `V4L2_CID_VBLANK`_\n \n .. _V4L2_CID_EXPOSURE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n .. _V4L2_CID_HBLANK: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-source.html\n .. _V4L2_CID_PIXEL_RATE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html\n+.. _V4L2_CID_VBLANK: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-source.html\n \n While V4L2 doesn't specify a unit for the `EXPOSURE` control, libcamera requires\n it to be expressed as a number of image lines. Camera sensor drivers that do not\n comply with this requirement will need to be adapted or will produce incorrect\n results.\n \n-The `HBLANK` and `PIXEL_RATE` controls are used to compute the sensor output\n-timings.\n+The `HBLANK`, `PIXEL_RATE` and `VBLANK` controls are used to compute the sensor\n+output timings.\n \n Optional Requirements\n ---------------------\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex ca33c0094088..ab315bdc468c 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -244,6 +244,7 @@ int CameraSensor::validateSensorDriver()\n \t\tV4L2_CID_EXPOSURE,\n \t\tV4L2_CID_HBLANK,\n \t\tV4L2_CID_PIXEL_RATE,\n+\t\tV4L2_CID_VBLANK,\n \t};\n \n \tControlList ctrls = subdev_->getControls(mandatoryControls);\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }