Patch Detail
Show a patch.
GET /api/1.1/patches/10995/?format=api
{ "id": 10995, "url": "https://patchwork.libcamera.org/api/1.1/patches/10995/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10995/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210126082628.1902267-1-hiroh@chromium.org>", "date": "2021-01-26T08:26:28", "name": "[libcamera-devel,v2] subprojects: Add libyuv and built if -Dandroid=enabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e2b10cdd46811ec60def4f9fc968b01b76910c4d", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10995/mbox/", "series": [ { "id": 1607, "url": "https://patchwork.libcamera.org/api/1.1/series/1607/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1607", "date": "2021-01-26T08:26:28", "name": "[libcamera-devel,v2] subprojects: Add libyuv and built if -Dandroid=enabled", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1607/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10995/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10995/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D305BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Jan 2021 08:26:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC3AE682DF;\n\tTue, 26 Jan 2021 09:26:37 +0100 (CET)", "from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n\t[IPv6:2607:f8b0:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E38D96030D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jan 2021 09:26:35 +0100 (CET)", "by mail-pl1-x631.google.com with SMTP id b17so2848938plz.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jan 2021 00:26:35 -0800 (PST)", "from hiroh.c.googlers.com.com\n\t(128.141.236.35.bc.googleusercontent.com. [35.236.141.128])\n\tby smtp.gmail.com with ESMTPSA id\n\ta141sm18639430pfa.189.2021.01.26.00.26.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Jan 2021 00:26:33 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"L4wmEP5l\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=LZHptJTRcTPsXUDLXpCekRFYMM8YodM2eFfN9sAyTco=;\n\tb=L4wmEP5lhkYZ3bqTWXnsiYtbRelWYbmVzB8hXhBMQ7u9UW+0y5fehjJFwA6avePhDf\n\tEy6el4fk9SCBAi1N1nKSagmNl0jYvv8hEHFWa0sdRVrulwLVVmLCpBzdYXsvZpyVhX2c\n\tLE7N6uhGEyC3L8nH4YzxZSegtAC3gd3FojXD8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=LZHptJTRcTPsXUDLXpCekRFYMM8YodM2eFfN9sAyTco=;\n\tb=rT+6RKaBVZCqdRW+f5LPFoNCsCBmnCxasFAEiKaCyR1P8Eor7n7h06+N+WA/4+DFnf\n\tvHN8EWeaTO/ADmAcmMf7Nr2k/cn69aYjiUE+GUdH2AMflpHyIaY0UjIbSXEMZJbsTHcj\n\tNtxr9FmingX8ezzOphTuvZcsR8p2OuNrShxeDrXXFE66VeQL8thsV+3RryCbq7nbrMkW\n\twTJP8jRIcMfZsNCd6h6QfXWuaGWTwo9avtvbOL0QeB73df+0IW6ypQrD0blr2kMn5F11\n\tJJbeaGggyzXpAqf08ujd8RWb+LbDZr3X8gwxv6XUwX9r/vNZOEXVIEQd1bnpqER1mpOO\n\toIBg==", "X-Gm-Message-State": "AOAM532tSSKc8vh+MWnM7WI/dDy/rryuUqiZVRdxshlF++pIHTpkX1N4\n\trAaSXGZQIuuheIcT+bYsW7jdzOt+j72t1MWa", "X-Google-Smtp-Source": "ABdhPJzloqsA+vRCAEzuDZCxwcqh+lqnmyf/OgNer5zhmrrmK5hoTjwmJOZGRQUPkkHnEXtl/TErXg==", "X-Received": "by 2002:a17:90b:46cc:: with SMTP id\n\tjx12mr4760909pjb.97.1611649594074; \n\tTue, 26 Jan 2021 00:26:34 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Jan 2021 08:26:28 +0000", "Message-Id": "<20210126082628.1902267-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.30.0.280.ga3ce27912f-goog", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2] subprojects: Add libyuv and built if\n\t-Dandroid=enabled", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Android HAL adaptation layer may need image processing, for\nexample, scaling and format conversion. Libyuv is a general image\nprocessing. This adds libyuv to subprojects, so that it is folked\nlocally and can be used with Android HAL implementation code.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n README.rst | 2 +-\n meson.build | 2 +-\n src/android/meson.build | 18 ++++++++++++++++++\n subprojects/.gitignore | 1 +\n subprojects/libyuv.wrap | 4 ++++\n 5 files changed, 25 insertions(+), 2 deletions(-)\n create mode 100644 subprojects/.gitignore\n create mode 100644 subprojects/libyuv.wrap\n\n--\n2.30.0.280.ga3ce27912f-goog", "diff": "diff --git a/README.rst b/README.rst\nindex 251291b7..08bfd5ad 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -47,7 +47,7 @@ A C++ toolchain: [required]\n \tEither {g++, clang}\n\n Meson Build system: [required]\n- meson (>= 0.51) ninja-build pkg-config\n+ meson (>= 0.55) ninja-build pkg-config\n\n If your distribution doesn't provide a recent enough version of meson,\n you can install or upgrade it using pip3.\ndiff --git a/meson.build b/meson.build\nindex c47eb420..d9b63278 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1,7 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n\n project('libcamera', 'c', 'cpp',\n- meson_version : '>= 0.51',\n+ meson_version : '>= 0.55',\n version : '0.0.0',\n default_options : [\n 'werror=true',\ndiff --git a/src/android/meson.build b/src/android/meson.build\nindex 3d4d3be4..e1533d7c 100644\n--- a/src/android/meson.build\n+++ b/src/android/meson.build\n@@ -14,6 +14,24 @@ foreach dep : android_deps\n endif\n endforeach\n\n+if android_enabled\n+ cmake = import('cmake')\n+\n+ libyuv_vars = cmake.subproject_options()\n+ libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n+ libyuv_vars.set_override_option('cpp_std', 'c++17')\n+ libyuv_vars.append_compile_args('cpp',\n+ '-Wno-sign-compare',\n+ '-Wno-unused-variable',\n+ '-Wno-unused-parameter')\n+ libyuv_vars.append_link_args('-ljpeg')\n+ libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n+ libyuv_dep = libyuv.dependency('yuv')\n+\n+ android_deps += [ libyuv_dep, ]\n+endif\n+\n+\n android_hal_sources = files([\n 'camera3_hal.cpp',\n 'camera_hal_manager.cpp',\ndiff --git a/subprojects/.gitignore b/subprojects/.gitignore\nnew file mode 100644\nindex 00000000..410b8bd6\n--- /dev/null\n+++ b/subprojects/.gitignore\n@@ -0,0 +1 @@\n+/libyuv\n\\ No newline at end of file\ndiff --git a/subprojects/libyuv.wrap b/subprojects/libyuv.wrap\nnew file mode 100644\nindex 00000000..8ba51fa0\n--- /dev/null\n+++ b/subprojects/libyuv.wrap\n@@ -0,0 +1,4 @@\n+[wrap-git]\n+directory = libyuv\n+url = https://chromium.googlesource.com/libyuv/libyuv.git\n+revision = 93b1b332cd60b56ab90aea14182755e379c28a80\n", "prefixes": [ "libcamera-devel", "v2" ] }