Patch Detail
Show a patch.
GET /api/1.1/patches/10985/?format=api
{ "id": 10985, "url": "https://patchwork.libcamera.org/api/1.1/patches/10985/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10985/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210125071444.26252-8-paul.elder@ideasonboard.com>", "date": "2021-01-25T07:14:43", "name": "[libcamera-devel,v4,7/8] android: camera_device: Cache request metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "36b4aade83f802f4a394ed8480ebe894a168b3d6", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10985/mbox/", "series": [ { "id": 1603, "url": "https://patchwork.libcamera.org/api/1.1/series/1603/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1603", "date": "2021-01-25T07:14:36", "name": "Fill in android result metadata and EXIF tags", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1603/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10985/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10985/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 622AEC0F2B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Jan 2021 07:15:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E1D3682B5;\n\tMon, 25 Jan 2021 08:15:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40A4F682A0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Jan 2021 08:15:11 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F1E83E;\n\tMon, 25 Jan 2021 08:15:08 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o0VFO2JW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611558911;\n\tbh=fEHYRnVKDxIJ3DteNfKAKKIz9m8zVBI5LbT43da0sek=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o0VFO2JWWHk4caT2SaCGWLVdqTewhT9/oiulaHuNfAyy4hXuO7oMSebUBs77z9Rus\n\tMLkB3qH9ZflfT8H2ZkU1Ge3ElQddNCL4ATkzDcUzUSmxhUOlW2WHrR0HoXysB8/IqB\n\tgfyJLLMOM8EvYzHlE2peb3BlSXDzSPxQ1MuvajN0=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 25 Jan 2021 16:14:43 +0900", "Message-Id": "<20210125071444.26252-8-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210125071444.26252-1-paul.elder@ideasonboard.com>", "References": "<20210125071444.26252-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 7/8] android: camera_device: Cache\n\trequest metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The settings in an android capture request may be null, in which case\nthe settings from the most recently submitted capture request should be\nused. Cache the request settings to achieve this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nChanges in v4:\n- use default CameraMetadata constructor for lastSettings_ (so no\n initialization in CameraDevice constructor)\n- add todo for incremental caching of android request settings\n\nChanges in v3:\n- rebase on \"android: camera device and metatada improvements\", so it's\n a bit cleaner\n\nNew in v2\n---\n src/android/camera_device.cpp | 6 +++++-\n src/android/camera_device.h | 2 ++\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3068f89f..9330db39 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1688,9 +1688,13 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t * The descriptor and the associated memory reserved here are freed\n \t * at request complete time.\n \t */\n-\t/* \\todo Handle null request settings */\n \tCamera3RequestDescriptor *descriptor =\n \t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request);\n+\t/* \\todo Set cache incrementally? */\n+\tif (camera3Request->settings)\n+\t\tlastSettings_ = camera3Request->settings;\n+\telse\n+\t\tdescriptor->settings_ = lastSettings_;\n \n \tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n \t\t\t<< descriptor->numBuffers_ << \" HAL streams\";\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 058a3f9a..fa4fb544 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -134,6 +134,8 @@ private:\n \tint orientation_;\n \n \tunsigned int maxJpegBufferSize_;\n+\n+\tCameraMetadata lastSettings_;\n };\n \n #endif /* __ANDROID_CAMERA_DEVICE_H__ */\n", "prefixes": [ "libcamera-devel", "v4", "7/8" ] }