Patch Detail
Show a patch.
GET /api/1.1/patches/10956/?format=api
{ "id": 10956, "url": "https://patchwork.libcamera.org/api/1.1/patches/10956/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10956/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210122102211.12768-6-david.plowman@raspberrypi.com>", "date": "2021-01-22T10:22:11", "name": "[libcamera-devel,5/5] ipa: raspberrypi: Remove legacy Rasberry Pi logging", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e60fcd020d7ce699b891608f46b3ac1d35d51d52", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10956/mbox/", "series": [ { "id": 1597, "url": "https://patchwork.libcamera.org/api/1.1/series/1597/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1597", "date": "2021-01-22T10:22:06", "name": "Remove Raspberry Pi logging", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1597/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10956/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10956/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8697EBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Jan 2021 10:22:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 538D46824C;\n\tFri, 22 Jan 2021 11:22:31 +0100 (CET)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9E896824C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Jan 2021 11:22:28 +0100 (CET)", "by mail-wr1-x431.google.com with SMTP id q7so4523257wre.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Jan 2021 02:22:28 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tp15sm11469221wrt.15.2021.01.22.02.22.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Jan 2021 02:22:27 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"foj0cTBF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=lzoNnOT+b8DgxM8JeMLr4xrkmbTMR3H8ANBYbi4GV84=;\n\tb=foj0cTBF+94MuM+BPTlZOnRUS6+z4Cuu7CiuI+DqHrRzsALWrT1HIz9OuMYNe8mF+I\n\talmXaLkuE3BTvsO8EAOF/s4r1MzvG9Ac9kAYjRFbCvmZTzUmSR7ftA6vPoGDf2I4z16v\n\tPfX9E2vckGn/atN/NMXmln2q9MYaRpCU5xBwQbHEJO3993mut3Ds/9EUgykTa/Bhs8vI\n\tB+EldkgSPDP+e6ACG7hmr6bcduYC4kY3lMmG9BLbKndgr6MMcq6+Xe0xL9QoVR8GRcEn\n\tQCp7FL7oiUFgtrD7osTYKpbSpAwBU98hQer/UZY6psEk/pWMTHAYUkuHNDvJhg8MRQiA\n\tmG2w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=lzoNnOT+b8DgxM8JeMLr4xrkmbTMR3H8ANBYbi4GV84=;\n\tb=W0YyOUSaGHKywhZff9G1HF31MxJEK8AWwseS7TSG+ZmCqOUTPSolSr7QNAgF2OUFUk\n\t+mnaibzLGfzW/2Q18JVRiNnxrRFS6sKe9Vd1bwXC1nBFUWa167JFj9Ig7To+FSamFjh3\n\tvK9UjKOTTRulr3IxplfI1G64mM2Dr96iJdeCc72s33+/KvyG9g7jYy3RLcbpFSnqW3ne\n\tdwAUHd+nBm9Mt/2A0ZvNFZy3HwRifUKx79PDl+hCZYduG9jvTG46+BtB9PmZ2QM2bTz4\n\tpnVrD3TKd5gi6xQGFSmSKXxJMsa7uKxgyD6YZpEH1OEZ9FdjVMlj81LP6VJUpJRkxxEb\n\tdHQQ==", "X-Gm-Message-State": "AOAM530BzZDNYIpfvBkchyaz+UicMgcyqaRDsec0r6nTJ+ZO7UClcHmJ\n\tMWzn8qLQZMZkKui6twd2D4To8xkYW/JtZwMQ", "X-Google-Smtp-Source": "ABdhPJxIDci1P6ADmdRHdDLDlO6/MFdokR6UNy6d5Kl68N97fkj4UIgVowRoGVlwIt7I49iFDzpgAA==", "X-Received": "by 2002:a5d:4d86:: with SMTP id b6mr3779501wru.152.1611310948190;\n\tFri, 22 Jan 2021 02:22:28 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 22 Jan 2021 10:22:11 +0000", "Message-Id": "<20210122102211.12768-6-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210122102211.12768-1-david.plowman@raspberrypi.com>", "References": "<20210122102211.12768-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Remove legacy\n\tRasberry Pi logging", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n src/ipa/raspberrypi/controller/logging.hpp | 30 --------------------\n 2 files changed, 31 deletions(-)\n delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp", "diff": "diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp\nindex 17423f23..e9b040c7 100644\n--- a/src/ipa/raspberrypi/controller/algorithm.hpp\n+++ b/src/ipa/raspberrypi/controller/algorithm.hpp\n@@ -14,7 +14,6 @@\n #include <map>\n #include <atomic>\n \n-#include \"logging.hpp\"\n #include \"controller.hpp\"\n \n #include <boost/property_tree/ptree.hpp>\ndiff --git a/src/ipa/raspberrypi/controller/logging.hpp b/src/ipa/raspberrypi/controller/logging.hpp\ndeleted file mode 100644\nindex f0d306b6..00000000\n--- a/src/ipa/raspberrypi/controller/logging.hpp\n+++ /dev/null\n@@ -1,30 +0,0 @@\n-/* SPDX-License-Identifier: BSD-2-Clause */\n-/*\n- * Copyright (C) 2019-2020, Raspberry Pi (Trading) Limited\n- *\n- * logging.hpp - logging macros\n- */\n-#pragma once\n-\n-#include <iostream>\n-\n-#ifndef RPI_LOGGING_ENABLE\n-#define RPI_LOGGING_ENABLE 0\n-#endif\n-\n-#ifndef RPI_WARNING_ENABLE\n-#define RPI_WARNING_ENABLE 1\n-#endif\n-\n-#define RPI_LOG(stuff) \\\n-\tdo { \\\n-\t\tif (RPI_LOGGING_ENABLE) \\\n-\t\t\tstd::cout << __FUNCTION__ << \": \" << stuff << \"\\n\"; \\\n-\t} while (0)\n-\n-#define RPI_WARN(stuff) \\\n-\tdo { \\\n-\t\tif (RPI_WARNING_ENABLE) \\\n-\t\t\tstd::cout << __FUNCTION__ << \" ***WARNING*** \" \\\n-\t\t\t\t << stuff << \"\\n\"; \\\n-\t} while (0)\n", "prefixes": [ "libcamera-devel", "5/5" ] }