Patch Detail
Show a patch.
GET /api/1.1/patches/10932/?format=api
{ "id": 10932, "url": "https://patchwork.libcamera.org/api/1.1/patches/10932/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10932/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210121165305.367801-5-jacopo@jmondi.org>", "date": "2021-01-21T16:53:02", "name": "[libcamera-devel,4/7] android: camera_metadata: Add defaul constructor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8cf1a900378e752baf01053241e1ea225b6b7214", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10932/mbox/", "series": [ { "id": 1593, "url": "https://patchwork.libcamera.org/api/1.1/series/1593/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1593", "date": "2021-01-21T16:52:58", "name": "android: camera device and metadata improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1593/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10932/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10932/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63538BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jan 2021 16:53:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F0B96821A;\n\tThu, 21 Jan 2021 17:53:03 +0100 (CET)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1068E6820F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 17:52:58 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id A69E61C0004;\n\tThu, 21 Jan 2021 16:52:57 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Date": "Thu, 21 Jan 2021 17:53:02 +0100", "Message-Id": "<20210121165305.367801-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210121165305.367801-1-jacopo@jmondi.org>", "References": "<20210121165305.367801-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/7] android: camera_metadata: Add defaul\n\tconstructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a default constructor that initializes a non valid CameraMetadata\nto allow embedding instances of the class in other types.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_metadata.cpp | 5 +++++\n src/android/camera_metadata.h | 1 +\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex 8e36e758d231..6f1bcdbe274a 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -13,6 +13,11 @@ using namespace libcamera;\n \n LOG_DEFINE_CATEGORY(CameraMetadata)\n \n+CameraMetadata::CameraMetadata()\n+\t: metadata_(nullptr), valid_(false)\n+{\n+}\n+\n CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n {\n \tmetadata_ = allocate_camera_metadata(entryCapacity, dataCapacity);\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 720b760d44da..d653e2f0f502 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -14,6 +14,7 @@\n class CameraMetadata\n {\n public:\n+\tCameraMetadata();\n \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n \tCameraMetadata(const camera_metadata_t *metadata);\n \tCameraMetadata(const CameraMetadata &other);\n", "prefixes": [ "libcamera-devel", "4/7" ] }