Patch Detail
Show a patch.
GET /api/1.1/patches/10921/?format=api
{ "id": 10921, "url": "https://patchwork.libcamera.org/api/1.1/patches/10921/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10921/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210121101549.134574-10-paul.elder@ideasonboard.com>", "date": "2021-01-21T10:15:49", "name": "[libcamera-devel,v2,9/9] android: camera_device: Cache request metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d94157047dadae52f2115f2f63cf31a5cb60741e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10921/mbox/", "series": [ { "id": 1590, "url": "https://patchwork.libcamera.org/api/1.1/series/1590/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1590", "date": "2021-01-21T10:15:40", "name": "Fill in android result metadata and EXIF tags", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1590/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10921/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10921/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83F30C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jan 2021 10:16:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51C95681EF;\n\tThu, 21 Jan 2021 11:16:20 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19B78681EF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jan 2021 11:16:19 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD66550E;\n\tThu, 21 Jan 2021 11:16:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lflWmg1O\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611224178;\n\tbh=mjONAGbRA+tc5z85O+RqaqpU94ZOA1u56IAhNeFbSbQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lflWmg1O0iG+AE9WCFzEou2aXO2c/XenEc/qNEdMi7nCBv6xZbK0vF8Rvb3X77l6r\n\trX8VIiSKJvRSpQ6sF6IIHEXJE3FxiQD/lBEkQntoozB96Sq9KL8hJV9q+eUTEc/RLy\n\trw0vUjAOdKG5paXu/8WPlNhbCUiacAU4qbl1gu2c=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Jan 2021 19:15:49 +0900", "Message-Id": "<20210121101549.134574-10-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210121101549.134574-1-paul.elder@ideasonboard.com>", "References": "<20210121101549.134574-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 9/9] android: camera_device: Cache\n\trequest metadata", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The settings in an android capture request may be null, in which case\nthe settings from the most recently submitted capture request should be\nused. Cache the request settings to achieve this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v2\n---\n src/android/camera_device.cpp | 10 ++++++----\n src/android/camera_device.h | 2 ++\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1b803c92..4f92cecc 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -337,7 +337,9 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n \n CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr<Camera> &camera)\n \t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n-\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n+\t facing_(CAMERA_FACING_FRONT), orientation_(0),\n+\t /* \\todo Keep this in sync with the actual number of entries. */\n+\t lastSettings_(CameraMetadata(40, 163))\n {\n \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n \n@@ -1692,12 +1694,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t * The descriptor and the associated memory reserved here are freed\n \t * at request complete time.\n \t */\n-\t/* \\todo Handle null request settings */\n-\tCameraMetadata settings(camera3Request->settings);\n+\tif (camera3Request->settings)\n+\t\tlastSettings_ = CameraMetadata(camera3Request->settings);\n \tCamera3RequestDescriptor *descriptor =\n \t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request->frame_number,\n \t\t\t\t\t camera3Request->num_output_buffers,\n-\t\t\t\t\t settings);\n+\t\t\t\t\t lastSettings_);\n \n \tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n \t\t\t<< descriptor->numBuffers_ << \" HAL streams\";\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 111a7d8f..d3a9f777 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -139,6 +139,8 @@ private:\n \tint orientation_;\n \n \tunsigned int maxJpegBufferSize_;\n+\n+\tCameraMetadata lastSettings_;\n };\n \n #endif /* __ANDROID_CAMERA_DEVICE_H__ */\n", "prefixes": [ "libcamera-devel", "v2", "9/9" ] }