Patch Detail
Show a patch.
GET /api/1.1/patches/10900/?format=api
{ "id": 10900, "url": "https://patchwork.libcamera.org/api/1.1/patches/10900/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10900/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210119153047.468190-1-naush@raspberrypi.com>", "date": "2021-01-19T15:30:45", "name": "[libcamera-devel,v12,1/3] libcamera: controls: Add frame duration control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6ab5664afedd82214f6cb86f8fc8f07f304b7bdd", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10900/mbox/", "series": [ { "id": 1585, "url": "https://patchwork.libcamera.org/api/1.1/series/1585/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1585", "date": "2021-01-19T15:30:45", "name": "[libcamera-devel,v12,1/3] libcamera: controls: Add frame duration control", "version": 12, "mbox": "https://patchwork.libcamera.org/series/1585/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10900/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10900/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31759C0F1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jan 2021 15:30:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A99456815B;\n\tTue, 19 Jan 2021 16:30:53 +0100 (CET)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 818DD6814E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jan 2021 16:30:52 +0100 (CET)", "by mail-wm1-x336.google.com with SMTP id c127so116322wmf.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jan 2021 07:30:52 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tk9sm5373970wma.17.2021.01.19.07.30.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 19 Jan 2021 07:30:51 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"VVpGZT6M\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=HDZCTbJRCBRdw1De4jc2Td6h4U0eYFlyY/7WXINUGog=;\n\tb=VVpGZT6M6iTk4R1HyCkHUKz2Tvnhcbzn/PpzGQLqOjnOl1PsRNNaDHmJK7JpBKqvy6\n\tgHerrl14jT+nX2r3qxTN4XqrMNFocVADbtVy+oq73+7bOlE8/R0VwYUnDhD5AQuyNK3M\n\tyC1lyg0zK9HRmtxnPLHhJdSxcINs1tg0EpDhvtUYI8haUlXIz7+1JAsOE2lRkGZ0yJoK\n\tZnMfJFeuId4+L9kM9KTb9SjYmCf8Lr4RMIi1nms6TM8A1gyNOOoUDRBPlxlKozSHW1VZ\n\tkkEOrBTKkUf6uU7osk0ad7VYxFtGOQAMbP9LFVyqASj6UtxXSqEIRawV4IhNUM95KV5G\n\t9utg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=HDZCTbJRCBRdw1De4jc2Td6h4U0eYFlyY/7WXINUGog=;\n\tb=l/i354k8jDnrprY8Pfx77XMQRFK/oC6V5pYiguqLw78Mqs142J6a8852ouuEGQe4jN\n\tHO9JMDzQlNN7m0qGOxvo5vabIU2fVyOGNy/Qf3sj3QO41XmkGUbaHUPBqv/t+RKqLI6d\n\trNwFx+e4vfsCLDo0FGqvU9hVOd0ZgJPT6eu4ifRdlWR0feau71uXKE+IhWcpIbLTT2BJ\n\t0pJHXyN/Vr+MQLaC8xjDlZKg8DYhXFDF2fAH/3wfrgn1BLbGYWYkn3etFBKk8CpaiKq2\n\tkU4PBvxSSic5gH3LJbnYW3tmgKN+Cz39f9tWIklDdKw8XxyTjMwhdhA/+NUan4+wIvk2\n\t88hQ==", "X-Gm-Message-State": "AOAM5329KmepCyNIyyvEX1kLLQKiJBB0hnfLbQDQPIgBEPtE/yZjBtX0\n\tSfMWltBo0NCjBrOAB4GN2v16BGEv7nQ0Fg==", "X-Google-Smtp-Source": "ABdhPJzMfW4qX3qnbcVKZnncFaiK9dUmvbxDB0y46fE//+X0znkzkv1fTxMQfiXlf0jaHX4fxBd5mA==", "X-Received": "by 2002:a1c:a784:: with SMTP id q126mr197637wme.52.1611070251950;\n\tTue, 19 Jan 2021 07:30:51 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 19 Jan 2021 15:30:45 +0000", "Message-Id": "<20210119153047.468190-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v12 1/3] libcamera: controls: Add frame\n\tduration control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an int64_t array control (controls::FrameDurations) to specify the\nminimum and maximum (in that order) frame duration to be used by the\ncamera sensor.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 36 ++++++++++++++++++++++++++++++++++\n 1 file changed, 36 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 6d6f0fee508b..36c37161a3d5 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -306,6 +306,42 @@ controls:\n maximum valid value is given by the properties::ScalerCropMaximum\n property, and the two can be used to implement digital zoom.\n \n+ - FrameDurations:\n+ type: int64_t\n+ description: |\n+ The minimum and maximum (in that order) frame duration,\n+ expressed in micro-seconds.\n+\n+ When provided by applications, the control specifies the sensor frame\n+ duration interval the pipeline has to use. This limits the largest\n+ exposure time the sensor can use. For example, if a maximum frame\n+ duration of 33ms is requested (corresponding to 30 frames per second),\n+ the sensor will not be able to raise the exposure time above 33ms.\n+ A fixed frame duration is achieved by setting the minimum and maximum\n+ values to be the same. Setting both values to 0 reverts to using the\n+ IPA provided defaults.\n+\n+ The maximum frame duration provides the absolute limit to the shutter\n+ speed computed by the AE algorithm and it overrides any exposure mode\n+ setting specified with controls::AeExposureMode. Similarly, when a\n+ manual exposure time is set through controls::ExposureTime, it also\n+ gets clipped to the limits set by this control. When reported in\n+ metadata, the control expresses the minimum and maximum frame\n+ durations used after being clipped to the sensor provided frame\n+ duration limits.\n+\n+ \\sa AeExposureMode\n+ \\sa ExposureTime\n+\n+ \\todo Define how to calculate the capture frame rate by\n+ defining controls to report additional delays introduced by\n+ the capture pipeline or post-processing stages (ie JPEG\n+ conversion, frame scaling).\n+\n+ \\todo Provide an explicit definition of default control values, for\n+ this and all other controls.\n+ size: [2]\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n", "prefixes": [ "libcamera-devel", "v12", "1/3" ] }