Patch Detail
Show a patch.
GET /api/1.1/patches/10870/?format=api
{ "id": 10870, "url": "https://patchwork.libcamera.org/api/1.1/patches/10870/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10870/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210115170033.27124-8-jacopo@jmondi.org>", "date": "2021-01-15T17:00:30", "name": "[libcamera-devel,v7,07/10] libcamera: uvc: Initialize the pixel array properties", "commit_ref": "89b495c054e5704bb68a1cbc876e575c91499b47", "pull_url": null, "state": "accepted", "archived": false, "hash": "66aeb2db7377b0e882e8138314521be78ba2034f", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10870/mbox/", "series": [ { "id": 1578, "url": "https://patchwork.libcamera.org/api/1.1/series/1578/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1578", "date": "2021-01-15T17:00:23", "name": "libcamera: camera_sensor: Make validation more strict", "version": 7, "mbox": "https://patchwork.libcamera.org/series/1578/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10870/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10870/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 223D7C3383\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jan 2021 17:00:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D07368117;\n\tFri, 15 Jan 2021 18:00:25 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FBC6680F6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jan 2021 18:00:20 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6C638240011\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jan 2021 17:00:20 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 15 Jan 2021 18:00:30 +0100", "Message-Id": "<20210115170033.27124-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210115170033.27124-1-jacopo@jmondi.org>", "References": "<20210115170033.27124-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v7 07/10] libcamera: uvc: Initialize the\n\tpixel array properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialize the pixel array properties in the UVC pipeline handler as\nthey're now initialized in the CameraSensor class, which the UVC\npipeline handler does not use.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 7cb310e20511..08a594175091 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -509,6 +509,22 @@ int UVCCameraData::init(MediaDevice *media)\n \tproperties_.set(properties::Location, properties::CameraLocationExternal);\n \tproperties_.set(properties::Model, utils::toAscii(media->model()));\n \n+\t/*\n+\t * Get the current format in order to initialize the sensor array\n+\t * properties.\n+\t */\n+\tSize resolution;\n+\tfor (const auto &it : video_->formats()) {\n+\t\tconst std::vector<SizeRange> &sizeRanges = it.second;\n+\t\tfor (const SizeRange &sizeRange : sizeRanges) {\n+\t\t\tif (sizeRange.max > resolution)\n+\t\t\t\tresolution = sizeRange.max;\n+\t\t}\n+\t}\n+\n+\tproperties_.set(properties::PixelArraySize, resolution);\n+\tproperties_.set(properties::PixelArrayActiveAreas, { Rectangle(resolution) });\n+\n \t/* Initialise the supported controls. */\n \tControlInfoMap::Map ctrls;\n \n", "prefixes": [ "libcamera-devel", "v7", "07/10" ] }