Patch Detail
Show a patch.
GET /api/1.1/patches/1087/?format=api
{ "id": 1087, "url": "https://patchwork.libcamera.org/api/1.1/patches/1087/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1087/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190419132531.17856-2-jacopo@jmondi.org>", "date": "2019-04-19T13:25:24", "name": "[libcamera-devel,v8,1/8] libcamera: stream: Document protected members", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dbcbfd54cf83a3d5b840d0767aaab1a4cd3f79cf", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1087/mbox/", "series": [ { "id": 263, "url": "https://patchwork.libcamera.org/api/1.1/series/263/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=263", "date": "2019-04-19T13:25:23", "name": "libcamera: ipu3: Multiple streams support", "version": 8, "mbox": "https://patchwork.libcamera.org/series/263/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1087/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1087/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 937F260B2E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Apr 2019 15:24:44 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DE15220003;\n\tFri, 19 Apr 2019 13:24:43 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 19 Apr 2019 15:25:24 +0200", "Message-Id": "<20190419132531.17856-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190419132531.17856-1-jacopo@jmondi.org>", "References": "<20190419132531.17856-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v8 1/8] libcamera: stream: Document\n\tprotected members", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 19 Apr 2019 13:24:44 -0000" }, "content": "Since commit: 4e1dc9004fca (\"libcamera: stream: Make Stream inheritable\")\nthe private members of the Stream class have been turned into protected,\nto allows subclasses to access them.\n\nAs Doxygen generates documentation for protected members (but not for\nprivate memebers), add documentation to the stream class for the\n'bufferMap_' and 'configuration_' members.\n\nFixes: 4e1dc9004fca (\"libcamera: stream: Make Stream inheritable\")\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/stream.cpp | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 71dd461db33b..aeb479c57b37 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -211,4 +211,22 @@ Stream::Stream()\n * \\return The active configuration of the stream\n */\n \n+/**\n+ * \\var Stream::bufferPool_\n+ * \\brief The pool of buffers associated with the stream\n+ *\n+ * The stream buffer pool is populated by the Camera class after a succesfull\n+ * stream configuration.\n+ */\n+\n+/**\n+ * \\var Stream::configuration_\n+ * \\brief The stream configuration\n+ *\n+ * The configuration for the stream is set by any successful call to\n+ * Camera::configureStreams() that includes the stream, and remains valid until\n+ * the next call to Camera::configureStreams() regardless of if it includes the\n+ * stream.\n+ */\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v8", "1/8" ] }