Patch Detail
Show a patch.
GET /api/1.1/patches/10859/?format=api
{ "id": 10859, "url": "https://patchwork.libcamera.org/api/1.1/patches/10859/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10859/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210114104035.302968-4-paul.elder@ideasonboard.com>", "date": "2021-01-14T10:40:32", "name": "[libcamera-devel,3/6] android: jpeg: exif: Fix setOrientation EXIF values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bb3fb3a0058e217e305272f78b57dec2c67fb55b", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10859/mbox/", "series": [ { "id": 1577, "url": "https://patchwork.libcamera.org/api/1.1/series/1577/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1577", "date": "2021-01-14T10:40:29", "name": "Fill in android result metadata and EXIF tags", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1577/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10859/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10859/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E69CBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 14 Jan 2021 10:40:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13908680EE;\n\tThu, 14 Jan 2021 11:40:55 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC241680EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 14 Jan 2021 11:40:52 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C5572B3;\n\tThu, 14 Jan 2021 11:40:51 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TqwG8S4f\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610620852;\n\tbh=YIQQi7xsGwtzDtccnM54ffdg6Vlye9Txn5Xv7DX1SXI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TqwG8S4fYtKsrg7az7rQhgfJLSKbjma2qNsjL7IucaBkqF7xO6GWoWw0hR7WYQyjR\n\tv1iEl2CJnM/AWNAHdawzyVsibLFgcpTbeSzl33sA3LnaTAkbeB8ezgGfKBtTYVR+IK\n\tpEannnr8ulGddkFGwFG/lFAQ1g82cLjKdGWLWsdU=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 14 Jan 2021 19:40:32 +0900", "Message-Id": "<20210114104035.302968-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210114104035.302968-1-paul.elder@ideasonboard.com>", "References": "<20210114104035.302968-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/6] android: jpeg: exif: Fix\n\tsetOrientation EXIF values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The input to setOrientation is angle clockwise from 12 o'clock, while\nthe EXIF output values were swapped for 90 and 270 degrees.\n\nFrom the EXIF spec:\n\n6 = The 0th row is the visual right-hand side of the image, and the\n 0th column is the visual top.\n8 = The 0th row is the visual left-hand side of the image, and the\n 0th column is the visual bottom.\n\n6 should be 90 degrees clockwise, while 8 should 270 degrees clockwise.\nFix this.\n\nSogned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/jpeg/exif.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex 33b3fa7f..b19cb4cd 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -263,13 +263,13 @@ void Exif::setOrientation(int orientation)\n \t\tvalue = 1;\n \t\tbreak;\n \tcase 90:\n-\t\tvalue = 8;\n+\t\tvalue = 6;\n \t\tbreak;\n \tcase 180:\n \t\tvalue = 3;\n \t\tbreak;\n \tcase 270:\n-\t\tvalue = 6;\n+\t\tvalue = 8;\n \t\tbreak;\n \t}\n \n", "prefixes": [ "libcamera-devel", "3/6" ] }