Patch Detail
Show a patch.
GET /api/1.1/patches/10839/?format=api
{ "id": 10839, "url": "https://patchwork.libcamera.org/api/1.1/patches/10839/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10839/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210107094735.11673-8-jacopo@jmondi.org>", "date": "2021-01-07T09:47:32", "name": "[libcamera-devel,v6,07/10] libcamera: uvc: Initialize the pixel array properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "362f12d66ae202301fb8df91aac45439f22fd420", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10839/mbox/", "series": [ { "id": 1571, "url": "https://patchwork.libcamera.org/api/1.1/series/1571/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1571", "date": "2021-01-07T09:47:25", "name": "libcamera: camera_sensor: Make validation more strict", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1571/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10839/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10839/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04EA9C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Jan 2021 09:47:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4D9B67F69;\n\tThu, 7 Jan 2021 10:47:33 +0100 (CET)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01CB863411\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Jan 2021 10:47:32 +0100 (CET)", "from uno.localdomain (unknown [93.56.74.111])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 9FD31FF806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Jan 2021 09:47:31 +0000 (UTC)" ], "X-Originating-IP": "93.56.74.111", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Jan 2021 10:47:32 +0100", "Message-Id": "<20210107094735.11673-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210107094735.11673-1-jacopo@jmondi.org>", "References": "<20210107094735.11673-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 07/10] libcamera: uvc: Initialize the\n\tpixel array properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialize the pixel array properties in the UVC pipeline handler as\nthey're now initialized in the CameraSensor class, which the UVC\npipeline handler does not use.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 7cb310e20511..e0c4131496be 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -509,6 +509,21 @@ int UVCCameraData::init(MediaDevice *media)\n \tproperties_.set(properties::Location, properties::CameraLocationExternal);\n \tproperties_.set(properties::Model, utils::toAscii(media->model()));\n \n+\t/*\n+\t * Get the current format in order to initialize the sensor array\n+\t * properties.\n+\t */\n+\tSize resolution{};\n+\tfor (const auto &[pixelformat, sizerange] : video_->formats()) {\n+\t\tfor (const SizeRange &size : sizerange) {\n+\t\t\tif (size.max > resolution)\n+\t\t\t\tresolution = size.max;\n+\t\t}\n+\t}\n+\n+\tproperties_.set(properties::PixelArraySize, resolution);\n+\tproperties_.set(properties::PixelArrayActiveAreas, { Rectangle(resolution) });\n+\n \t/* Initialise the supported controls. */\n \tControlInfoMap::Map ctrls;\n \n", "prefixes": [ "libcamera-devel", "v6", "07/10" ] }