Patch Detail
Show a patch.
GET /api/1.1/patches/10828/?format=api
{ "id": 10828, "url": "https://patchwork.libcamera.org/api/1.1/patches/10828/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10828/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210106100659.8363-2-naush@raspberrypi.com>", "date": "2021-01-06T10:06:57", "name": "[libcamera-devel,v11,1/3] libcamera: controls: Add frame duration control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "075dc5be75ab3ecba6947aa7932fe56f6410a6d2", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10828/mbox/", "series": [ { "id": 1569, "url": "https://patchwork.libcamera.org/api/1.1/series/1569/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1569", "date": "2021-01-06T10:06:56", "name": "raspberrypi: FPS control", "version": 11, "mbox": "https://patchwork.libcamera.org/series/1569/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10828/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10828/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB8E4C0F1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Jan 2021 10:07:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00A6A630BB;\n\tWed, 6 Jan 2021 11:07:06 +0100 (CET)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E0C062007\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Jan 2021 11:07:05 +0100 (CET)", "by mail-wr1-x42e.google.com with SMTP id y17so1855342wrr.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 06 Jan 2021 02:07:05 -0800 (PST)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tm21sm2382381wml.13.2021.01.06.02.07.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 Jan 2021 02:07:03 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BAeHGZ9d\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=gsim8+we0stMr/1j7X70QSAiPz8/X0X0Lc4hTx2MvLE=;\n\tb=BAeHGZ9daKFw2DTCCgkntoChKu8Pdrh/p4y8o3CcwUMZUXZmrCyeNmjzCbb7BIedWl\n\tWJMikmOncaSJCvPlJP6CrJu/7cDd5IR3T75qBhax7mR+iv27guI1/M6UygP0wFLcI7yn\n\tWHDghaQ5azmpgqsAL4JLNKXrlqXnzBhdpznUYNwd3ZO+J3M4tDWRoKoTgiQWtHgezoXn\n\tvagrsxmqTRQOj+IWLfDf1fXUnIvSrpkOY/xuqG0mWijjvduEJtCO1U8b3C4RT88bUAQ4\n\tfpz7MQOx0vssup4aeawHyKljKRJQ5jK15d44eEGili+vzg444X7PaNKSa39EVFlu0tyM\n\tXlNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=gsim8+we0stMr/1j7X70QSAiPz8/X0X0Lc4hTx2MvLE=;\n\tb=IZAE2I5gtlVc+TGWNcoHhhoCxJwAkONfkLisD1ZkW8paKJEPr79ZdXCyRVPGZO5v8/\n\t8yjbwTtWbhPLGwdUH6dz9ymmCvv+aiK3XRA1IXRDcoXzeyLybepPFOaWvYYHVwXAVXiS\n\tGyaxROgkoI0EFJ4xJFB4+rih8+lZWOhBdFY4qHWkQqaIBupSvHxW05bFyyBQ2yrC4dOo\n\tucDSZCTxZuRm4Qi9uGOe8KZYDTmoDMHu/1/I11Pogkik2LXVFEX4QeoUyAyLHShHQPtI\n\tnNwTSGP5rWjxDnbF9hVaU4QKUV9VlwpwoZViYnCMoJR+nREJSmDjO5o1Kzt59grv2Qe9\n\tx3yg==", "X-Gm-Message-State": "AOAM531zXQNuOqZw7qMsI9ZLcpbDwculUKpVHgPXf012srfpAqnuHAq/\n\tU1Y+CiUFCsVARsWb0q2kAok8DwLjm1BCzA==", "X-Google-Smtp-Source": "ABdhPJyUsBqCowal9i612gwMwkcepqrpXEIYtLd700jYyAMjzdNqLgTHJ6dvOZx4yxq1oQx9OWDtDQ==", "X-Received": "by 2002:a5d:604a:: with SMTP id\n\tj10mr3602728wrt.290.1609927624717; \n\tWed, 06 Jan 2021 02:07:04 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 6 Jan 2021 10:06:57 +0000", "Message-Id": "<20210106100659.8363-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210106100659.8363-1-naush@raspberrypi.com>", "References": "<20210106100659.8363-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v11 1/3] libcamera: controls: Add frame\n\tduration control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an int64_t array control (controls::FrameDurations) to specify the\nminimum and maximum (in that order) frame duration to be used by the\ncamera sensor.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 38 ++++++++++++++++++++++++++++++++++\n 1 file changed, 38 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 6d6f0fee..d1240beb 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -306,6 +306,44 @@ controls:\n maximum valid value is given by the properties::ScalerCropMaximum\n property, and the two can be used to implement digital zoom.\n \n+ - FrameDurations:\n+ type: int64_t\n+ description: |\n+ The minimum and maximum (in that order) frame duration,\n+ expressed in micro-seconds.\n+\n+ When provided by applications, the control specifies the sensor frame\n+ duration interval the pipeline has to use. This limits the largest\n+ exposure time the sensor can use. For example, if a maximum frame\n+ duration of 33ms is requested (corresponding to 30 frames per second),\n+ the sensor will not be able to raise the exposure time above 33ms.\n+ A fixed frame duration is achieved by setting the minimum and maximum\n+ values to be the same. Setting both values to 0 reverts to using the\n+ IPA provided defaults.\n+\n+ The maximum frame duration provides the absolute limit to the shutter\n+ speed computed by the AE algorithm and it overrides any exposure mode\n+ setting specified with controls::AeExposureMode. Similarly, when a\n+ manual exposure time is set through controls::ExposureTime, it also\n+ gets clipped to the limits set by this control. When reported in\n+ metadata, the control expresses the minimum and maximum frame\n+ durations used after being clipped to these limits.\n+\n+ \\sa AeExposureMode\n+ \\sa ExposureTime\n+\n+ \\todo Refer to the frame duration limits property to describe how\n+ application-provided values gets clipped and reset.\n+\n+ \\todo Define how to calculate the capture frame rate by\n+ defining controls to report additional delays introduced by\n+ the capture pipeline or post-processing stages (ie JPEG\n+ conversion, frame scaling).\n+\n+ \\todo Provide an explicit definition of default control values, for\n+ this and all other controls.\n+ size: [2]\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n", "prefixes": [ "libcamera-devel", "v11", "1/3" ] }