Patch Detail
Show a patch.
GET /api/1.1/patches/10747/?format=api
{ "id": 10747, "url": "https://patchwork.libcamera.org/api/1.1/patches/10747/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10747/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201224141904.28503-1-laurent.pinchart@ideasonboard.com>", "date": "2020-12-24T14:19:04", "name": "[libcamera-devel] libcamera: pipeline: simple: Remove the unused configs_ variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3d267e31ef60d8407d8daf01b36ada37b2fc989d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10747/mbox/", "series": [ { "id": 1553, "url": "https://patchwork.libcamera.org/api/1.1/series/1553/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1553", "date": "2020-12-24T14:19:04", "name": "[libcamera-devel] libcamera: pipeline: simple: Remove the unused configs_ variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1553/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10747/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10747/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34EE4C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Dec 2020 14:19:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFF0B615B0;\n\tThu, 24 Dec 2020 15:19:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F2D961598\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Dec 2020 15:19:17 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7BEBA1D;\n\tThu, 24 Dec 2020 15:19:15 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RE70nEqf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608819556;\n\tbh=hZPROO2Q3010psCJYhzdTe5+L3KSYc6aulNOuqux62w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=RE70nEqfE+66UpN8XLCtmpp08m9JQblULL0qOwWPeTXiQbsTkYmqSYfqcTz1BBnwD\n\tAfsbp+hojLMIhXub6VcMwCsXNQ/ruX1AYh3P3DGjPaiEu1Hbih5GTgBx7aP5LVAP0B\n\tjdg5+4955KRxNmhg2yR1POG7CQ4QULqs/jXnfl1s=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Dec 2020 16:19:04 +0200", "Message-Id": "<20201224141904.28503-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove the\n\tunused configs_ variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Phi-Bang Nguyen <pnguyen@baylibre.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Phi-Bang Nguyen <pnguyen@baylibre.com>\n\nRemove the unused configs_ member variable in SimpleCameraData.\n\nSigned-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex b719171ab6d1..57bfb29094ff 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -85,7 +85,6 @@ public:\n \tstd::list<Entity> entities_;\n \tV4L2VideoDevice *video_;\n \n-\tstd::vector<Configuration> configs_;\n \tstd::map<PixelFormat, Configuration> formats_;\n };\n \n", "prefixes": [ "libcamera-devel" ] }