Patch Detail
Show a patch.
GET /api/1.1/patches/10706/?format=api
{ "id": 10706, "url": "https://patchwork.libcamera.org/api/1.1/patches/10706/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10706/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201223174709.45457-6-jacopo@jmondi.org>", "date": "2020-12-23T17:47:08", "name": "[libcamera-devel,5/6] android: camera_device: Report ColorFilterArrangement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dddf2237e413bf745e4c26d0ed273a136a4a9f70", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10706/mbox/", "series": [ { "id": 1544, "url": "https://patchwork.libcamera.org/api/1.1/series/1544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1544", "date": "2020-12-23T17:47:03", "name": "android: support ColorFilterArrangement property", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10706/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10706/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E47F9C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Dec 2020 17:47:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 959F662007;\n\tWed, 23 Dec 2020 18:47:08 +0100 (CET)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4A606158A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 18:47:04 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AA461FF806\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 17:47:04 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 23 Dec 2020 18:47:08 +0100", "Message-Id": "<20201223174709.45457-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201223174709.45457-1-jacopo@jmondi.org>", "References": "<20201223174709.45457-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/6] android: camera_device: Report\n\tColorFilterArrangement", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Conditionally report the ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT\nproperty inspecting the draft property reported by the libcamera Camera.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex b4618a680f41..920baab254b6 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -897,9 +897,12 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n \t\t\t\t &sensitivityRange, 2);\n \n-\tuint16_t filterArr = ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT_GRBG;\n-\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n-\t\t\t\t &filterArr, 1);\n+\t/* Report the color filter arrangement: default it to GRBG. */\n+\tif (properties.contains(properties::draft::ColorFilterArrangement)) {\n+\t\tuint8_t filterArr = properties.get(properties::draft::ColorFilterArrangement);\n+\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n+\t\t\t\t\t &filterArr, 1);\n+\t}\n \n \tint64_t exposureTimeRange[] = {\n \t\t100000, 200000000,\n", "prefixes": [ "libcamera-devel", "5/6" ] }