Patch Detail
Show a patch.
GET /api/1.1/patches/10702/?format=api
{ "id": 10702, "url": "https://patchwork.libcamera.org/api/1.1/patches/10702/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10702/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201223174709.45457-2-jacopo@jmondi.org>", "date": "2020-12-23T17:47:04", "name": "[libcamera-devel,1/6] utils: gen-controls: Fix enumerators documentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "49b8095ad6062d94a1d510a60ea12bc1f6dcf028", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10702/mbox/", "series": [ { "id": 1544, "url": "https://patchwork.libcamera.org/api/1.1/series/1544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1544", "date": "2020-12-23T17:47:03", "name": "android: support ColorFilterArrangement property", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10702/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10702/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8136C0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 23 Dec 2020 17:47:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86E0F61FF3;\n\tWed, 23 Dec 2020 18:47:05 +0100 (CET)", "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1496760529\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 18:47:03 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id CF4B9FF804\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 23 Dec 2020 17:47:02 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 23 Dec 2020 18:47:04 +0100", "Message-Id": "<20201223174709.45457-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201223174709.45457-1-jacopo@jmondi.org>", "References": "<20201223174709.45457-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/6] utils: gen-controls: Fix enumerators\n\tdocumentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThe Doxygen documentation for enumerators prefixes the enumerator name\nwith the enumeration name. For unscoped enumerations, this is incorrect.\nDrop the scope. This fixes warnings produced by Doxygen when multiple\nenumerators with identical names are defined in different scopes.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n utils/gen-controls.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 12a32eaaeee9..3f99b5e2ba7d 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -26,7 +26,7 @@ def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n * \\\\brief Supported ${name} values''')\n- enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n+ enum_doc_value_template = string.Template(''' * \\\\var ${value}\n ${description}''')\n doc_template = string.Template('''/**\n * \\\\var ${name}\n", "prefixes": [ "libcamera-devel", "1/6" ] }