Patch Detail
Show a patch.
GET /api/1.1/patches/10696/?format=api
{ "id": 10696, "url": "https://patchwork.libcamera.org/api/1.1/patches/10696/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10696/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>", "date": "2020-12-22T16:15:26", "name": "[libcamera-devel] utils: gen-controls: Fix enumerators documentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "49b8095ad6062d94a1d510a60ea12bc1f6dcf028", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10696/mbox/", "series": [ { "id": 1541, "url": "https://patchwork.libcamera.org/api/1.1/series/1541/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1541", "date": "2020-12-22T16:15:26", "name": "[libcamera-devel] utils: gen-controls: Fix enumerators documentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1541/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10696/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10696/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01C9FC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Dec 2020 16:15:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89E01615AC;\n\tTue, 22 Dec 2020 17:15:41 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 965AA60528\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Dec 2020 17:15:39 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1277C2CF;\n\tTue, 22 Dec 2020 17:15:38 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FdLfWlIh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608653739;\n\tbh=fauCoHZ8SEO5sH009VjXsikD3SKdJRGqbcI/Bdq1YBc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FdLfWlIhuAv6C0uTX24iH9OWKGw+JcWioRVy8fBcpdg86pCQgP50ucwdjHeNCZe7A\n\tfyjQawQjog0FWJftrO2S/c5PtflZOA6GenGv2h4EvjWDQy422rLWqmMjoYqU/qovTO\n\tp3Pho/P20cRmrsjgTNYbp6J5AtiWEJaztURQpb74=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 22 Dec 2020 18:15:26 +0200", "Message-Id": "<20201222161526.13841-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] utils: gen-controls: Fix enumerators\n\tdocumentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Doxygen documentation for enumerators prefixes the enumerator name\nwith the enumeration name. For unscoped enumerations, this is incorrect.\nDrop the scope. This fixes warnings produced by Doxygen when multiple\nenumerators with identical names are defined in different scopes.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/gen-controls.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\nJacopo, I believe this should fix the issue you've experienced in your\ncamera sensor database series.", "diff": "diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 12a32eaaeee9..3f99b5e2ba7d 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -26,7 +26,7 @@ def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n * \\\\brief Supported ${name} values''')\n- enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n+ enum_doc_value_template = string.Template(''' * \\\\var ${value}\n ${description}''')\n doc_template = string.Template('''/**\n * \\\\var ${name}\n", "prefixes": [ "libcamera-devel" ] }