Patch Detail
Show a patch.
GET /api/1.1/patches/10683/?format=api
{ "id": 10683, "url": "https://patchwork.libcamera.org/api/1.1/patches/10683/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10683/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201218164754.81422-3-jacopo@jmondi.org>", "date": "2020-12-18T16:47:47", "name": "[libcamera-devel,v2,2/9] libcamera: properties: ColorFilterArrangement draft property", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f662227f3720462ce994ad0c4d9da207ede1834d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10683/mbox/", "series": [ { "id": 1538, "url": "https://patchwork.libcamera.org/api/1.1/series/1538/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1538", "date": "2020-12-18T16:47:45", "name": "libcamera: Introduce sensor database", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1538/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10683/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10683/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFECBC0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Dec 2020 16:47:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A53B3619AF;\n\tFri, 18 Dec 2020 17:47:52 +0100 (CET)", "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C8B16052C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 17:47:50 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0A7DF20012\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 16:47:49 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Dec 2020 17:47:47 +0100", "Message-Id": "<20201218164754.81422-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201218164754.81422-1-jacopo@jmondi.org>", "References": "<20201218164754.81422-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/9] libcamera: properties:\n\tColorFilterArrangement draft property", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Define the 'ColorFilterArrangement' draft property. The property is\ncurrently identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n\nThis patch introdues the following warnings\nproperty_ids.cpp:716: warning: no matching class member found for\n libcamera::properties::draft::ColorFilterArrangementEnum::RGGB\nproperty_ids.cpp:719: warning: no matching class member found for\n libcamera::properties::draft::ColorFilterArrangementEnum::GRBG\nproperty_ids.cpp:722: warning: no matching class member found for\n libcamera::properties::draft::ColorFilterArrangementEnum::GBRG\nproperty_ids.cpp:725: warning: no matching class member found for\n libcamera::properties::draft::ColorFilterArrangementEnum::BGGR\n\nRemoving one letter from the identifiers, or adding one, makes the\nwarning disapper:\n\n--\n2.29.2", "diff": "diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 411d5b2a398d..8a19b989e6c4 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -697,16 +697,16 @@ controls:\n top-left 2x2 section of the sensor, in reading order. Currently\n identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n enum:\n- - name: RGGB\n+ - name: RGGBZ\n value: 0\n description: RGGB color filter arrangement\n- - name: GRBG\n+ - name: GRBGZ\n value: 1\n description: GRBG color filter arrangement\n- - name: GBRG\n+ - name: GBRGZ\n value: 2\n description: GBRG color filter arrangement\n- - name: BGGR\n+ - name: BGGRZ\n value: 3\n description: BGGR color filter arrangement\n - name: RGB\n\nA Doxygen bug maybe ?\n\n---\n src/libcamera/property_ids.yaml | 26 ++++++++++++++++++++++++++\n 1 file changed, 26 insertions(+)\n\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex f8e32c1bd8cf..411d5b2a398d 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -689,4 +689,30 @@ controls:\n The physical dimensions of the full pixel array in millimeters.\n Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.\n\n+ - ColorFilterArrangement:\n+ type: int32_t\n+ draft: true\n+ description: |\n+ The arrangement of color filters on sensor; represents the colors in the\n+ top-left 2x2 section of the sensor, in reading order. Currently\n+ identical to ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT.\n+ enum:\n+ - name: RGGB\n+ value: 0\n+ description: RGGB color filter arrangement\n+ - name: GRBG\n+ value: 1\n+ description: GRBG color filter arrangement\n+ - name: GBRG\n+ value: 2\n+ description: GBRG color filter arrangement\n+ - name: BGGR\n+ value: 3\n+ description: BGGR color filter arrangement\n+ - name: RGB\n+ value: 4\n+ description: |\n+ Sensor is not Bayer; output has 3 16-bit values for each pixel,\n+ instead of just 1 16-bit value per pixel.\n+\n ...\n", "prefixes": [ "libcamera-devel", "v2", "2/9" ] }