Patch Detail
Show a patch.
GET /api/1.1/patches/10678/?format=api
{ "id": 10678, "url": "https://patchwork.libcamera.org/api/1.1/patches/10678/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10678/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201218100626.205134-2-naush@raspberrypi.com>", "date": "2020-12-18T10:06:25", "name": "[libcamera-devel,v10,1/3] libcamera: controls: Add frame duration control", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "a0ef434bdf8634e5b7b29ce112ab13098076f955", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10678/mbox/", "series": [ { "id": 1537, "url": "https://patchwork.libcamera.org/api/1.1/series/1537/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1537", "date": "2020-12-18T10:06:24", "name": "raspberrypi: FPS control", "version": 10, "mbox": "https://patchwork.libcamera.org/series/1537/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10678/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10678/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD971C0F1A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Dec 2020 10:07:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 766AE61593;\n\tFri, 18 Dec 2020 11:07:02 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 014C361593\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 11:07:00 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id k10so1762962wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Dec 2020 02:07:00 -0800 (PST)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tc4sm11836424wmf.19.2020.12.18.02.06.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Dec 2020 02:06:58 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"T851rUO2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=toNVQHPqikeKHtw7h2O9IrIFWTVBv1gYRnO0mkIhmkI=;\n\tb=T851rUO2KEyKQjqzHFtOjycWN2hK6AsAwcIx6JRUomxEDneQ0j/9Rvvj/s+xyHRHBt\n\tAAJiWfwJ0Yw1RxC51dtvGY+tXz96DMlz5FuChrwW5WStswiu/MTL4GUlu0fX0FBWBECu\n\te4rGgbWMuXlERP5Ty2CmOQqzcM1hnGgMNZG6GAGHnTkRIugs6rPo3LMr0aik4VpN+zhQ\n\ttdkkFKA9qjeZVj6HDwMfSxa5My8D0ad4AfjTDkk1gE8jCp+/6JjmpnBLhjgSCXO8p9s+\n\t8Oi770goABjH3+CQXHuUBX2lKqhEPYr9KDx5EKFIPDPk4h3+B55QlNj1nIum9sR9i8yC\n\thfIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=toNVQHPqikeKHtw7h2O9IrIFWTVBv1gYRnO0mkIhmkI=;\n\tb=suAH5i0YEp6tapWA68vgMqFdUyd3aGE0hUwwSwlTRs6S/OUU11d1iqW+ZwA6lIL0u1\n\ti4hMFlybADuOflI4eg1y4o4N5omUUW79fPcitTgrrGJYK8/9q1Meet/XFriGmAPUDeLm\n\tQuIcqmNFi2GKnXt05uaWo+0O2FdOWRlm3m9K3dVdwNlSVsUB9jrKmmnf6T/KrEga+TUq\n\tdtKMSXaE6GkGFZnTUOfoNQGDvrFVCg6Ws75UCJcaeOhsos+V8uPRuDj10SkzKwEip9Gn\n\tseMvqEv18aQ8tscFUztOhawV/o4m+gkZ5/mOIdJKwne3JPZHGnQ3vQqNZHgsWzeNzWSO\n\t3L0g==", "X-Gm-Message-State": "AOAM533Jjf7hkY9IKpAhE8RAvbnkY7SJmmkLHoO7+QETXYlSeQSoG1EF\n\tPdkVmaQQKJKmP3AXfB6BZjZtqbVCa3SoPg==", "X-Google-Smtp-Source": "ABdhPJxXt10EUc//r3RT/SsVg4FT5ogpacwT/BlK79WJDifkZ+xalms015oviK6fcqZPdWR0dI/QCQ==", "X-Received": "by 2002:a05:600c:208:: with SMTP id\n\t8mr3523582wmi.146.1608286019428; \n\tFri, 18 Dec 2020 02:06:59 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Dec 2020 10:06:25 +0000", "Message-Id": "<20201218100626.205134-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201218100626.205134-1-naush@raspberrypi.com>", "References": "<20201218100626.205134-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v10 1/3] libcamera: controls: Add frame\n\tduration control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an int64_t array control (controls::FrameDurations) to specify the\nminimum and maximum (in that order) frame duration to be used by the\ncamera sensor.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 41 ++++++++++++++++++++++++++++++++++\n 1 file changed, 41 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 6d6f0fee..a58bff18 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -306,6 +306,47 @@ controls:\n maximum valid value is given by the properties::ScalerCropMaximum\n property, and the two can be used to implement digital zoom.\n \n+ - FrameDurations:\n+ type: int64_t\n+ description: |\n+ The minimum and maximum (in that order) frame duration,\n+ expressed in micro-seconds.\n+\n+ When provided by applications, the control specifies the sensor frame\n+ duration interval the pipeline has to use. This could also limit the\n+ largest exposure time the sensor can use. For example, if a maximum\n+ frame duration of 33ms is requested (corresponding to 30 frames per\n+ second), the sensor will not be able to raise the exposure time above\n+ 33ms. A fixed frame duration is achieved by setting the minimum and\n+ maximum values to be the same.\n+\n+ The maximum frame duration provides the absolute limit to the shutter\n+ speed computed by the AE algorithm and it overrides any exposure mode\n+ setting specified with controls::AeExposureMode. Similarly, when a\n+ manual exposure time is set through controls::ExposureTime, it also\n+ gets clipped to the limits set by this control.\n+\n+ \\sa AeExposureMode\n+ \\sa ExposureTime\n+\n+ \\todo Refer to the frame duration limits property to describe how\n+ application-provided values gets clipped and reset.\n+\n+ When reported by pipelines, the control expresses the minimum and\n+ maximum frame durations used after being clipped to what the current\n+ sensor mode supports, and what is achievable based on the exposure\n+ mode setting specified with controls::AeExposureMode or manual\n+ exposure time set through controls::ExposureTime. The sensor frame\n+ duration is one of the parameter that defines the capture frame rate\n+ but it does not alone provide enough information to fully calculate it\n+ as it does not account for pipeline processing delays.\n+\n+ \\todo Define how to calculate the capture frame rate by\n+ defining controls to report additional delays introduced by\n+ the capture pipeline or post-processing stages (ie JPEG\n+ conversion, frame scaling).\n+ size: [2]\n+\n # ----------------------------------------------------------------------------\n # Draft controls section\n \n", "prefixes": [ "libcamera-devel", "v10", "1/3" ] }