Patch Detail
Show a patch.
GET /api/1.1/patches/10638/?format=api
{ "id": 10638, "url": "https://patchwork.libcamera.org/api/1.1/patches/10638/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10638/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201210175939.166033-1-jacopo@jmondi.org>", "date": "2020-12-10T17:59:39", "name": "[libcamera-devel] android: camera_device: Temporary fix sensor properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d3cf7cd5c04efb7a884ebeaa4f467643aa3286e6", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10638/mbox/", "series": [ { "id": 1523, "url": "https://patchwork.libcamera.org/api/1.1/series/1523/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1523", "date": "2020-12-10T17:59:39", "name": "[libcamera-devel] android: camera_device: Temporary fix sensor properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1523/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10638/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10638/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37365BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Dec 2020 17:59:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C59FD6089C;\n\tThu, 10 Dec 2020 18:59:33 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A0826084B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Dec 2020 18:59:33 +0100 (CET)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id F2037240003\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Dec 2020 17:59:32 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 10 Dec 2020 18:59:39 +0100", "Message-Id": "<20201210175939.166033-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] android: camera_device: Temporary fix\n\tsensor properties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ChromeOS camera service, which is the current main user of the\nAndroid Camera HAL, fails to start if the pixel array properties are\nnot registered.\n\nAs the sensor driver for the Soraka test device have not yet been\nupdated to report their pixel array properties through the V4L2\nselection API, temporary fix the gap by re-establishing the default\nproperties values removed by commit 1889cdc2e91c (\"android: camera_device:\nInitialize pixel array properties\")\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex e9fb23175d27..8b46e2d1e4ba 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -735,6 +735,10 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t};\n \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n \t\t\t\t\t data.data(), data.size());\n+\t} else {\n+\t\tint32_t data[] = { 2592, 1944 };\n+\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n+\t\t\t\t\t data, 2);\n \t}\n \n \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n@@ -748,6 +752,10 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t};\n \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n \t\t\t\t\t data.data(), data.size());\n+\t} else {\n+\t\tint32_t data[] = { 0, 0, 2560, 1920 };\n+\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n+\t\t\t\t\t data, 4);\n \t}\n \n \tint32_t sensitivityRange[] = {\n", "prefixes": [ "libcamera-devel" ] }