Patch Detail
Show a patch.
GET /api/1.1/patches/10594/?format=api
{ "id": 10594, "url": "https://patchwork.libcamera.org/api/1.1/patches/10594/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10594/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201207150737.307692-3-kieran.bingham@ideasonboard.com>", "date": "2020-12-07T15:07:35", "name": "[libcamera-devel,2/4] src: meson: Simplify v4l2 enablement", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a22e3fec423489a9b0889d763b36c3a7fa1f5636", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10594/mbox/", "series": [ { "id": 1510, "url": "https://patchwork.libcamera.org/api/1.1/series/1510/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1510", "date": "2020-12-07T15:07:33", "name": "libcamera: Small meson-fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1510/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10594/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10594/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FD73BDB20\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Dec 2020 15:07:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2BED67E4E;\n\tMon, 7 Dec 2020 16:07:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 223CB67E51\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Dec 2020 16:07:44 +0100 (CET)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 956768D;\n\tMon, 7 Dec 2020 16:07:43 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g8G7DY1X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607353663;\n\tbh=twvfnWI7D11NJkfo1eU2Xx2SflgBrLQMyuGTXrKuVsw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g8G7DY1XtXGLAy3tbrc7GHFYPa7bnV0/TMOEyQyr3VbRkbuv42c1UIePNjgfEFLtu\n\tO56Fgf74qCGxUEYCQIudSv/OU1yz2w870Zw+zTP85wxh9W05QMLPzkLYpL8Oczn+8O\n\ta/Lj57V3uAjgQGFstV9hkxG5q0SDbjiO1Pxz9ptc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 7 Dec 2020 15:07:35 +0000", "Message-Id": "<20201207150737.307692-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201207150737.307692-1-kieran.bingham@ideasonboard.com>", "References": "<20201207150737.307692-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/4] src: meson: Simplify v4l2 enablement", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Simplify the src level meson file by moving the declaration of the v4l2 subdir\nto match the other invocations, making use of 'subdir_done()' to break out if the\nadaptation layer is not enabled.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/meson.build | 5 +----\n src/v4l2/meson.build | 4 ++++\n 2 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/meson.build b/src/meson.build\nindex 8e219943acb8..4b75f05878bc 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -21,8 +21,5 @@ subdir('ipa')\n subdir('cam')\n subdir('qcam')\n \n-if get_option('v4l2')\n- subdir('v4l2')\n-endif\n-\n subdir('gstreamer')\n+subdir('v4l2')\ndiff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex e3838f0b07cc..dbe6a424b10e 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -1,5 +1,9 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+if not get_option('v4l2')\n+ subdir_done()\n+endif\n+\n v4l2_compat_sources = files([\n 'v4l2_camera.cpp',\n 'v4l2_camera_file.cpp',\n", "prefixes": [ "libcamera-devel", "2/4" ] }