Patch Detail
Show a patch.
GET /api/1.1/patches/10554/?format=api
{ "id": 10554, "url": "https://patchwork.libcamera.org/api/1.1/patches/10554/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10554/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201204065452.2764628-3-email@uajain.com>", "date": "2020-12-04T06:54:50", "name": "[libcamera-devel,v3,2/4] simple-cam: Early return if no cameras are found on the system.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1485139dd8022d553ae64fc1536fb57e1c7b2092", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10554/mbox/", "series": [ { "id": 1502, "url": "https://patchwork.libcamera.org/api/1.1/series/1502/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1502", "date": "2020-12-04T06:54:48", "name": "simple-cam: Provide event-loop backed by libevent", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1502/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10554/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10554/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7863BE177\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Dec 2020 06:55:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4B79635D6;\n\tFri, 4 Dec 2020 07:55:07 +0100 (CET)", "from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED816635C4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Dec 2020 07:55:05 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"IS0vGEWN\"; dkim-atps=neutral", "From": "Umang Jain <email@uajain.com>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1607064905; bh=OMmssAISbEHqoBoqkvh61nTusb+34VnOj2cq0UfiYt4=;\n\th=From:To:Cc:Subject:In-Reply-To:References;\n\tb=IS0vGEWN8ciGOyVQ+d8kAoG6vm0PYUXNLbMJV6fLHjmu3fGIBVfV3Hdoc7CMqtZd7\n\tOHrBrNzhmtNdqU9tEBsxSGZvJeUxKqIAcxbfK2b4QCmju0W5wNtbb30zEVn0CObyB9\n\tk63k5mB9GuNG/WS3Nf1UoOhWBnqw5v3yKA7zYY1wZFc1XOQRfalheWT6+BOdwny0lR\n\tjs/yYZKe2qzW2pK0WZshLUWDvEZFfEKM3R3aktfPc8hPWST2bA1V5++8nRFx+KrNAS\n\tVnjbpSra5/dXyAhNqQ610UidXf1lBHg6dwVh8otw7kmzBBvVpK9pBhwdY0amHxJFzh\n\tQ5d+pXr3rYgKw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 4 Dec 2020 12:24:50 +0530", "Message-Id": "<20201204065452.2764628-3-email@uajain.com>", "In-Reply-To": "<20201204065452.2764628-1-email@uajain.com>", "References": "<20201204065452.2764628-1-email@uajain.com>", "Mime-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 2/4] simple-cam: Early return if no\n\tcameras are found on the system.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Failing to do so, the codepath will segfault while trying to acquire\na non-existent camera.\n\nSigned-off-by: Umang Jain <email@uajain.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n simple-cam.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex e88fb85..aace5c8 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -307,6 +307,13 @@ int main()\n \tfor (std::unique_ptr<Request> &request : requests)\n \t\tcamera->queueRequest(request.get());\n \n+\tif (!cm->cameras().size()) {\n+\t\tstd::cout << \"No cameras were identified on the system.\"\n+\t\t\t << std::endl;\n+\t\tcm->stop();\n+\t\treturn EXIT_FAILURE;\n+\t}\n+\n \t/*\n \t * --------------------------------------------------------------------\n \t * Run an EventLoop\n", "prefixes": [ "libcamera-devel", "v3", "2/4" ] }