Patch Detail
Show a patch.
GET /api/1.1/patches/10542/?format=api
{ "id": 10542, "url": "https://patchwork.libcamera.org/api/1.1/patches/10542/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10542/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201202115253.14705-2-david.plowman@raspberrypi.com>", "date": "2020-12-02T11:52:49", "name": "[libcamera-devel,1/5] src: ipa: raspberrypi: Distinguish the first camera start from others", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "750638026ba6d86fa874a26f425e907ef15ba8d4", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10542/mbox/", "series": [ { "id": 1500, "url": "https://patchwork.libcamera.org/api/1.1/series/1500/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1500", "date": "2020-12-02T11:52:48", "name": "Raspberry Pi AGC: initial frame drop count", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1500/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10542/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10542/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C5BCBE177\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Dec 2020 11:53:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2525634A2;\n\tWed, 2 Dec 2020 12:53:00 +0100 (CET)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D826635A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Dec 2020 12:52:59 +0100 (CET)", "by mail-wr1-x42a.google.com with SMTP id p8so3558234wrx.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 02 Dec 2020 03:52:59 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tn189sm1739215wmf.20.2020.12.02.03.52.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Dec 2020 03:52:58 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ja/daMsS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Hmm1WGdx4I+pN4Vv1vhTrXS7T6AbovSVEaKZpFzO8uc=;\n\tb=Ja/daMsSeYgdmdU5Be+e/S/848Hc+B3LhxFRD5m8EuOZJBnmAWL6YRlkluDzU99G7M\n\ts1SlX8ca2MFlnspptWvTiqHKYAcV6n17aiVyUS52dFKg/Xeo3eUtJzB1oAQhrpQoi+oT\n\t/FF9NevHcJkHzTTdMWfLf7EpEtpSWxtDCf91/pd+Kh7dO/5h2pvfZ6YOgMW/p8EmC7ye\n\tVcbiNvA+1U+8VHwOAg/6b7Ow1nIZDGGryajf4wEp0TupulxCdSbYIXSRBEurdqgPl/XF\n\tNB10jOk7dcFZs9wqzpvQUhyZC5XPcPsanvFDb3hOg8ZLxUXgtOPMVTWkxXmsV47XAN22\n\t9T0g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Hmm1WGdx4I+pN4Vv1vhTrXS7T6AbovSVEaKZpFzO8uc=;\n\tb=Cgh2PS1UaNIgmZD9NhClfZSDACtSfvQiQT80Dgpzye56Y2UjFSr0ZHjvBxLx4hSvD4\n\tsVstBGHccy2uuG00GEz2X1QzftEDruFVxWfbLbIW0phQFcP69t9H3ke8QOEqY+TcABdt\n\tB6elufttqKKxA0E8XKepr/OKFDed0GfGud59FpRpA1w2BAScH7R17TN9vmp5ZdR8R+R3\n\tBRfaT8k59Hdk1QEDgOKRP1wYIv2uWyP4vZgfSwsmZqcO6tBgyOvS/lAXFBt04sr9MUIE\n\tznh9G1WTcYgNOjyVzpdKpkua3EZ6jDc5uyKlp3TAVOAZTbgI+Ne+FkzwFZ+2lPx3nGqt\n\t24ug==", "X-Gm-Message-State": "AOAM531B+kGneylNcf3lDX8+K1Q2sYwq+CWRAWOA0HsIIwD9lmVKNCw2\n\tlp8VdZu/BKgoX0d7W6N5oCxIaCPbTPwX0bku", "X-Google-Smtp-Source": "ABdhPJzxv/nYP74jYUkmGJp9s48hl55AD5e6jGCyohgtnE+Mh1duFAJ9Zd0jcZ6GGYB3uD5qlF4BNw==", "X-Received": "by 2002:adf:a3c1:: with SMTP id m1mr3184816wrb.28.1606909978639; \n\tWed, 02 Dec 2020 03:52:58 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 2 Dec 2020 11:52:49 +0000", "Message-Id": "<20201202115253.14705-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201202115253.14705-1-david.plowman@raspberrypi.com>", "References": "<20201202115253.14705-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/5] src: ipa: raspberrypi: Distinguish\n\tthe first camera start from others", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This makes it possible to tell whether we're starting the sensor for\nthe first time, or whether it's happening because of a mode switch or\nbecause the camera has been paused and re-started. Depending on this,\nsome sensors may require us to drop different numbers of frames.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 69be5e4e..b8298768 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -67,7 +67,7 @@ public:\n \tIPARPi()\n \t\t: lastMode_({}), controller_(), controllerInit_(false),\n \t\t frameCount_(0), checkCount_(0), mistrustCount_(0),\n-\t\t lsTable_(nullptr)\n+\t\t lsTable_(nullptr), firstStart_(true)\n \t{\n \t}\n \n@@ -145,6 +145,9 @@ private:\n \t/* LS table allocation passed in from the pipeline handler. */\n \tFileDescriptor lsTableHandle_;\n \tvoid *lsTable_;\n+\n+\t/* Distinguish the first camera start from others. */\n+\tbool firstStart_;\n };\n \n int IPARPi::init(const IPASettings &settings)\n@@ -179,6 +182,8 @@ int IPARPi::start(const IPAOperationData &ipaConfig, IPAOperationData *result)\n \t\tresult->operation |= RPi::IPA_CONFIG_SENSOR;\n \t}\n \n+\tfirstStart_ = false;\n+\n \treturn 0;\n }\n \n", "prefixes": [ "libcamera-devel", "1/5" ] }