Patch Detail
Show a patch.
GET /api/1.1/patches/10517/?format=api
{ "id": 10517, "url": "https://patchwork.libcamera.org/api/1.1/patches/10517/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10517/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201127133738.880859-3-tomi.valkeinen@iki.fi>", "date": "2020-11-27T13:37:36", "name": "[libcamera-devel,RFC,v2,2/4] HACK: expose Camera* from Request", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "2b961e38f94fd7cb5cecc3db3743131850ae8e73", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/1.1/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10517/mbox/", "series": [ { "id": 1487, "url": "https://patchwork.libcamera.org/api/1.1/series/1487/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1487", "date": "2020-11-27T13:37:34", "name": "prototype python bindings", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1487/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10517/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10517/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3589BBE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Nov 2020 13:38:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BA3063475;\n\tFri, 27 Nov 2020 14:38:00 +0100 (CET)", "from mail-lj1-x230.google.com (mail-lj1-x230.google.com\n\t[IPv6:2a00:1450:4864:20::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71E8D6346F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Nov 2020 14:37:59 +0100 (CET)", "by mail-lj1-x230.google.com with SMTP id j10so5961378lja.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Nov 2020 05:37:59 -0800 (PST)", "from deskari.ti.com (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tz199sm690892lfc.42.2020.11.27.05.37.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Nov 2020 05:37:58 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LgTyJnsY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=UcPMN0dB2DN/VUM9wTqxxSQynbXUVyrYsOQZZ4wBYm8=;\n\tb=LgTyJnsYoiNZI4Of4A5GsXEGZApjRq0JQBpKdBLTxW+FyVWMzms26JOGNEXLVy7Xkb\n\ta1hzFHFXo22WtePykhl2Ge1UEDfLDBzVSL/+qshev6OXrQnyxFh7ajrxRkL9JtuioGjX\n\tXWMygs5XpbQf8H/dwlJhmJs1hEl+/CANSoh6bJTovy9BK6KW9VK5jKzwoafYeU/PqQe/\n\tzHhxXUQsD1bYQ5rSCpaotwaYEs44R+8/vZ6LTM/vd0tBPe9adWXT9zv56jmuyQE7Zvoa\n\teyh4ZmpF/A+fxHoudOpjXdjtjdrlulrCGDKI47JkLNJcL1Q0snq4nLL5CDZeJx4GuKuF\n\tjSAQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=UcPMN0dB2DN/VUM9wTqxxSQynbXUVyrYsOQZZ4wBYm8=;\n\tb=O9tBmHH2OQQJlZmCsha1IXmpm0sYBX3keZF6L4sZu6FF/3sF1Dxv+h7odb9fFXD3sc\n\tzT8zPXZ3jYoX50aFNCj9BfVlRj339lJl/1R6uZmbDedCUIH/jGeRYnH4x9acOO55/Ua+\n\t7BAtkioa/tNv4k8RZonKV+whPUPn6FwueVH0pokAHhOkDsMoed/n0UkntKpYqyLd7Xm1\n\tYSaTUUaBHc266IuoKjG20EDvEwQKbXWu/bKCEYUa7FC1UtLpH4PcmOZ2890yQTue15LY\n\tkYldjt+vY/q7tnhx7hWgvTlSZDpEXLowaQpkyAa0ovMY9Nt4enz/ZZqf9pK+ADVEU57o\n\t2Tnw==", "X-Gm-Message-State": "AOAM530/W9H7PTvtk26ZmSdpjOArQk0fOgNbrfqK2kdMnpM1Hl2S4SQD\n\tgEHNgOFiv2SDlxcRumfmSmXAYMGbU5w=", "X-Google-Smtp-Source": "ABdhPJyjCTd+koGTJwgIzbtVg1ugg9vWKDh9RGRaznU260JsJU1D6uEfBy/TrH+Fk6FcUfF5WE9FoQ==", "X-Received": "by 2002:a2e:8110:: with SMTP id\n\td16mr3327701ljg.280.1606484278753; \n\tFri, 27 Nov 2020 05:37:58 -0800 (PST)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Nov 2020 15:37:36 +0200", "Message-Id": "<20201127133738.880859-3-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201127133738.880859-1-tomi.valkeinen@iki.fi>", "References": "<20201127133738.880859-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC v2 2/4] HACK: expose Camera* from Request", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@ti.com>,\n\tTomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Py bindings need to find out which camera is the source of the completed\nRequest. Request already has a private field for the Camera, so we can\njust expose it via a getter.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>\n---\n include/libcamera/request.h | 1 +\n src/libcamera/request.cpp | 5 +++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 655b1324..f98ef767 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -56,6 +56,7 @@ public:\n \n \tbool hasPendingBuffers() const { return !pending_.empty(); }\n \n+ std::shared_ptr<Camera> camera() const;\n private:\n \tfriend class PipelineHandler;\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex a68684ef..5a50ec6b 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -216,6 +216,11 @@ FrameBuffer *Request::findBuffer(const Stream *stream) const\n \treturn it->second;\n }\n \n+std::shared_ptr<Camera> Request::camera() const\n+{\n+\treturn camera_->shared_from_this();\n+}\n+\n /**\n * \\fn Request::metadata()\n * \\brief Retrieve the request's metadata\n", "prefixes": [ "libcamera-devel", "RFC", "v2", "2/4" ] }